rpc: Compile on GCC4.8 #15248

1. 
   MarcoFalke commented at 12:54 AM on January 25, 2019: member

   GCC 4.8 is lacking some C++11 signatures (see "Adjust C++11 signatures to take a const_iterator." in GCC 4.9: https://github.com/gcc-mirror/gcc/commit/3d2b2f494d78e0f4168d2c7ba5a76c05b4f4af71)

   Fix that by changing the code to use the pre-GCC 4.9 signature.

   Can be reverted after #13356.

   Fixes #15172 (reports on Linux Mint 17.3 Rosa and CentOS Linux release 7.5.1804 (Core))

2. MarcoFalke added the label Refactoring on Jan 25, 2019
3. MarcoFalke added this to the milestone 0.18.0 on Jan 25, 2019
4. MarcoFalke cross-referenced this on Jan 25, 2019 from issue Error compiling Bitcoin Core on Centos 7.5 (with default gcc 4.8) by martinbehrens
5. 
   Empact commented at 1:03 AM on January 25, 2019: member

   utACK https://github.com/bitcoin/bitcoin/pull/15248/commits/fa27cddaf725769649bd4a475e80efc8c0f135cd I also ran into this working on building against Trusty #14998

   nit: maybe add a comment calling out the temporary fix?

6. 
   DrahtBot commented at 2:19 AM on January 25, 2019: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   No conflicts as of last run.

7. 
   laanwj commented at 1:33 PM on January 27, 2019: member

   I guess this is no longer necessary after #15262? Or is this entirely for backport to 0.17.2?

   Oh I misread, that is tagged 0.19.0.

8. 
   laanwj commented at 4:29 PM on January 27, 2019: member

   utACK, though I'd prefer to separate the refactoring/renaming commit from the actual change

            LOCK(g_rpc_server_info.mutex);
   -        it = g_rpc_server_info.active_commands.insert(g_rpc_server_info.active_commands.cend(), {method, GetTimeMicros()});
   +        it = g_rpc_server_info.active_commands.insert(g_rpc_server_info.active_commands.end(), {method, GetTimeMicros()});
   

9. rpc: Compile on GCC4.8 fa5f890aeb
10. MarcoFalke force-pushed on Jan 27, 2019
11. 
    gmaxwell commented at 10:25 AM on January 28, 2019: contributor

    tested ACK

12. MarcoFalke merged this on Jan 28, 2019
13. MarcoFalke closed this on Jan 28, 2019

    ---

14. MarcoFalke referenced this in commit d6e700e40f on Jan 28, 2019
15. MarcoFalke deleted the branch on Jan 28, 2019
16. bitcoin locked this on Dec 16, 2021

Contributors

MarcoFalkeEmpactDrahtBotlaanwjgmaxwell

Milestone
0.18.0