build: Solve SmartOS FD_ZERO build issue #15146

1. 
   Empact commented at 2:40 AM on January 11, 2019: member

   SmartOS FD_ZERO is implemented in a way that requires an external declaration of memcpy. We can not simply include cstring in the existing file because sanity_test_memcpy is attempting to replace memcpy.

   Instead split glibc_sanity into fdelt and memcpy files, and include <cstring> in glibc_sanity/fdelt.cpp.

   Fixes #13581, see also #13619

2. fanquake added the label Build system on Jan 11, 2019
3. Empact force-pushed on Jan 11, 2019
4. Empact force-pushed on Jan 11, 2019
5. 
   laanwj commented at 10:31 AM on January 11, 2019: member

   Concept ACK

6. MarcoFalke added the label Needs gitian build on Jan 11, 2019
7. DrahtBot removed the label Needs gitian build on Jan 12, 2019
8. 
   laanwj commented at 11:47 AM on January 16, 2019: member

   @theuni can you take a look please

9. Empact force-pushed on Jan 16, 2019
10. bitcoin deleted a comment on Feb 14, 2019
11. 
    DrahtBot commented at 4:57 PM on February 14, 2019: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

12. fanquake added the label Needs rebase on Feb 15, 2019
13. 
    fanquake commented at 3:08 PM on February 15, 2019: member

    Concept ACK

14. Empact force-pushed on Feb 25, 2019
15. DrahtBot removed the label Needs rebase on Feb 25, 2019
16. Empact force-pushed on Mar 5, 2019
17. Empact force-pushed on Mar 9, 2019
18. Empact force-pushed on Mar 9, 2019
19. 
    Empact commented at 5:43 PM on March 9, 2019: member

    Made an effort to pare this down significantly. Now only one new file, and the necessity of the cstring include is determined in configure.

20. Empact force-pushed on Mar 9, 2019
21. Empact force-pushed on Mar 9, 2019
22. Empact force-pushed on Mar 9, 2019
23. fanquake cross-referenced this on Mar 31, 2019 from issue bitcoin core does not compile on Solaris by kayront
24. Empact force-pushed on Apr 3, 2019
25. MarcoFalke added the label Needs gitian build on Apr 8, 2019
26. DrahtBot removed the label Needs gitian build on Apr 9, 2019
27. [moveonly] Split glibc sanity_test_fdelt out 7fb886b1b1
28. Include cstring for sanity_test_fdelt if required

    SmartOS FD_ZERO is implemented in a way that requires
    an external declaration of memcpy. We can not simply
    include cstring in the existing file because
    sanity_test_memcpy is attempting to replace memcpy, but we can do
    so here, now that the fdelt test is split out.

    b4fd0ca9be
29. Empact force-pushed on Apr 14, 2019
30. 
    Empact commented at 3:25 AM on April 14, 2019: member

    @MarcoFalke realized that in attempting to rebase earlier I unintentionally overwrote my later implementation (https://github.com/bitcoin/bitcoin/pull/15146#issuecomment-471204901) with the earlier. Restored the earlier implementation - would need gitian again.

31. bitcoin deleted a comment on Apr 15, 2019
32. 
    laanwj commented at 11:50 AM on June 7, 2019: member

    Code review an lightly tested (but not on SmartOS) ACK b4fd0ca9be14c81023db759c405c0f67cfa78166

33. MarcoFalke added the label Needs gitian build on Jun 7, 2019
34. MarcoFalke added this to the milestone 0.19.0 on Jun 7, 2019
35. 
    DrahtBot commented at 5:26 AM on June 9, 2019: contributor

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 5d2ccf0ce9ca1571c650a69319fb9c1e0b626ecb (master):

    Gitian builds for commit bb4d0dd694e6a0847e4c2c40d8c554bd4be9c6b1 (master and this pull):

36. DrahtBot removed the label Needs gitian build on Jun 9, 2019
37. MarcoFalke added the label Needs gitian build on Jun 11, 2019
38. 
    DrahtBot commented at 10:06 PM on June 11, 2019: contributor

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 8a503a6c6dd419921373f45d7aa6f1787c9b8884 (master):

    Gitian builds for commit 6ba19505d59dd0d06ea33a15daf7f86043c9f53a (master and this pull):

39. DrahtBot removed the label Needs gitian build on Jun 11, 2019
40. MarcoFalke added the label Needs gitian build on Jun 11, 2019
41. DrahtBot removed the label Needs gitian build on Jun 13, 2019
42. laanwj renamed this:
    Solve SmartOS FD_ZERO build issue
    build: Solve SmartOS FD_ZERO build issue
    on Sep 18, 2019
43. laanwj referenced this in commit dd8cf82e96 on Sep 18, 2019
44. laanwj merged this on Sep 18, 2019
45. laanwj closed this on Sep 18, 2019

    ---

46. MarcoFalke cross-referenced this on Sep 18, 2019 from issue [Illumos] test/test_bitcoin_fuzzy fails, symbol errors by kayront
47. Empact deleted the branch on Sep 18, 2019
48. Empact cross-referenced this on Sep 18, 2019 from issue Can't compile bitcoin for SmartOS - recipe for target 'compat/libbitcoin_util_a-glibc_sanity.o' failed by stacepellegrino
49. sidhujag referenced this in commit f5f7b1e08e on Sep 23, 2019
50. bitcoin deleted a comment on Oct 13, 2019
51. deadalnix referenced this in commit 5c0e43d97c on Jun 4, 2020
52. kwvg referenced this in commit 2f79e04a8e on Dec 4, 2021
53. kwvg referenced this in commit c53856c984 on Dec 8, 2021
54. kwvg referenced this in commit 79c7766095 on Dec 12, 2021
55. kwvg referenced this in commit 25468188bf on Dec 13, 2021
56. kwvg referenced this in commit 77021fadff on Dec 13, 2021
57. bitcoin locked this on Dec 16, 2021

Contributors

EmpactlaanwjDrahtBotfanquake

Milestone
0.19.0