tests: Fix cuckoocache_tests TSAN failure introduced in 14935. #14969

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:cuckoocache_tests changing 2 files +6 −3

practicalswift commented at 9:51 AM on December 15, 2018: contributor

Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967.

in src/test/cuckoocache_tests.cpp:224 in c07910b184 outdated

 220 | @@ -221,7 +221,7 @@ static void test_cache_erase_parallel(size_t megabytes)
 221 |              size_t start = ntodo*x;
 222 |              size_t end = ntodo*(x+1);
 223 |              for (uint32_t i = start; i < end; ++i)
 224 | -                BOOST_CHECK(set.contains(hashes[i], true));
 225 | +                set.contains(hashes[i], true);

sipa commented at 9:53 AM on December 15, 2018:

This is a statement with no effect

fanquake added the label Tests on Dec 15, 2018
ken2812221 commented at 12:52 PM on December 15, 2018: contributor

Could use assert instead
fanquake renamed this:
~~Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967.~~
tests: Fix cuckoocache_tests TSAN failure introduced in 14935.
on Dec 15, 2018
Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967. d98a29ec40
practicalswift commented at 3:20 PM on December 15, 2018: contributor

@sipa @ken2812221 Updated. Please re-review :-)
practicalswift cross-referenced this on Dec 15, 2018 from issue tests: Test for expected return values when calling functions returning a success code by practicalswift
laanwj commented at 6:48 PM on December 15, 2018: member

utACK (but squash please)
practicalswift force-pushed on Dec 15, 2018
practicalswift commented at 7:40 PM on December 15, 2018: contributor

@laanwj Squashed! :-)
Empact commented at 7:50 PM on December 15, 2018: member

utACK d98a29e
ken2812221 commented at 6:40 AM on December 16, 2018: contributor

utACK d98a29ec408590e54f405a7f8d232cd9dc5b14da
laanwj merged this on Dec 16, 2018
laanwj closed this on Dec 16, 2018
laanwj referenced this in commit 3424171685 on Dec 16, 2018
Empact cross-referenced this on Dec 17, 2018 from issue One Travis instance should run minimum supported QT version by Sjors
deadalnix referenced this in commit a06ba8d57a on Jun 22, 2020
practicalswift deleted the branch on Apr 10, 2021
dzutto referenced this in commit f339f3de57 on Sep 24, 2021
dzutto referenced this in commit 9d408b364a on Sep 24, 2021
dzutto referenced this in commit eb0a3d833d on Sep 24, 2021
dzutto referenced this in commit 298a64983f on Sep 27, 2021
PastaPastaPasta cross-referenced this on Sep 27, 2021 from issue Merge 0.18 PRs: #14268, #15408, #14094, #14935 and #14969 by dzutto
dzutto referenced this in commit 6e91a22d80 on Sep 30, 2021
UdjinM6 referenced this in commit 4c72a1a975 on Oct 1, 2021
kwvg referenced this in commit 1983b3602d on Oct 12, 2021
bitcoin locked this on Aug 18, 2022

Contributors

Labels

Linked (view graph)

#14821 Replace CAffectedKeysVisitor with descriptor based logic #14935 tests: Test for expected return values when calling functions returning a success code #14957 wallet: Initialize stop_block in CWallet::ScanForWalletTransactions #14967 TSAN issue in cuckoocache_erase_parallel_ok test after 14935 #14983 One Travis instance should run minimum supported QT version