revert removal of fstream.hpp header in fs.h #14768

pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:restore-fs-h-include-boost-fs-fstream changing 1 files +1 −0
  1. kallewoof commented at 5:42 AM on November 20, 2018: member

    We cannot (yet) remove the EXPECTED_BOOST_INCLUDES entry as this header is still needed in fs.h (see #14763).

    Partially reverts #14718.

  2. revert removal of fstream.hpp header in fs.h
    This is required for some architectures.
    e816b341ab
  3. meshcollider commented at 5:49 AM on November 20, 2018: contributor

    utACK

  4. meshcollider cross-referenced this on Nov 20, 2018 from issue Remove filesystem/fstream from EXPECTED_BOOST_INCLUDES by Sjors
  5. meshcollider added the label Refactoring on Nov 20, 2018
  6. ken2812221 commented at 6:01 AM on November 20, 2018: contributor

    utACK e816b341ab794fb84d89efb90b8c0f369d34d6ca

  7. AkioNak commented at 8:12 AM on November 20, 2018: contributor

    utACK e816b34

  8. laanwj commented at 8:57 AM on November 20, 2018: member

    how did this get missed on review/testing?

  9. Sjors commented at 9:02 AM on November 20, 2018: member

    Part of the problem is that apparantly Travis was down, and that wasn't noticed: #14763 (comment)

  10. laanwj commented at 9:06 AM on November 20, 2018: member

    Part of the problem is that apparantly Travis was down, and that wasn't noticed: #14763 (comment)

    Thanks!

    Anyhow obvious-utACK e816b341ab794fb84d89efb90b8c0f369d34d6ca

  11. laanwj merged this on Nov 20, 2018
  12. laanwj closed this on Nov 20, 2018

  13. laanwj referenced this in commit 1b99d153d0 on Nov 20, 2018
  14. kallewoof deleted the branch on Nov 20, 2018
  15. deadalnix referenced this in commit 4d562db5ae on Mar 20, 2020
  16. ftrader referenced this in commit 2084301181 on May 19, 2020
  17. Munkybooty referenced this in commit 5ee0ec4f56 on Jul 29, 2021
  18. Munkybooty referenced this in commit eba469e3b0 on Aug 3, 2021
  19. Munkybooty referenced this in commit eb9a3965c3 on Aug 5, 2021
  20. Munkybooty referenced this in commit 526fb543ca on Aug 8, 2021
  21. Munkybooty referenced this in commit e1c365e257 on Aug 9, 2021
  22. Munkybooty referenced this in commit de5d8af15d on Aug 11, 2021
  23. 5tefan referenced this in commit 6e92792f59 on Aug 12, 2021
  24. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:54 UTC