docs: Windows build docs are missing `make deploy` #14699

issue ch4ot1c opened this issue on November 9, 2018

ch4ot1c commented at 7:35 PM on November 9, 2018: contributor
When building for Windows (using doc/build-windows.md), I discovered the following steps were necessary but undocumented, in order to generate the installer:
```
sudo apt install nsis
make deploy
makensis share/setup.nsi
```
fanquake added the label Docs on Nov 9, 2018
fanquake added the label good first issue on Nov 10, 2018
LucianaMarques commented at 11:59 AM on November 17, 2018: contributor

Hi there, I'd like to work on this. Is there any PR on this already?
fanquake commented at 12:04 PM on November 17, 2018: member

@LucianaMarques no, feel free to make the changes and open one.
LucianaMarques cross-referenced this on Nov 17, 2018 from issue [Docs] Added NSIS install steps to build-windows.md by LucianaMarques
LucianaMarques commented at 1:01 PM on November 17, 2018: contributor

@fanquake pull request opened! thanks
laanwj commented at 7:27 PM on November 19, 2018: member

The last step is not necessary see my comment here: #14744 (comment)
fanquake cross-referenced this on Dec 13, 2018 from issue docs: add NSIS setup/install steps to windows docs by fanquake
MarcoFalke closed this on Dec 18, 2018
MarcoFalke referenced this in commit b545a7e337 on Dec 18, 2018
bitcoin locked this on Sep 8, 2021

Contributors

Labels