Move util files to directory #14555

As discussed here, this establishes a util/ directory to introduce more organizational structure and have a clear place for new util files. It's really not scary to review, it's just one big scripted diff.

The scripted diff will also run on non-git files that happen to be in the folder. Imo, this should be avoided by using a git ls-files with a filter or something.

<!--e57a25ab6845829454e8d69fc972939a-->Reviewers, this pull request conflicts with the following ones:

• #14585 (refactor: remove usage of locale dependent std::isspace by practicalswift)
• #14530 (Use RPCHelpMan to generate RPC doc strings by MarcoFalke)
• #14521 (qt, docs: Fix bitcoin-qt -version output formatting by hebasto)
• #14384 (Resolve validationinterface circular dependencies by 251Labs)
• #14224 (Document intentional and unintentional unsigned integer overflows (wraparounds) using annotations by practicalswift)
• #14047 (Add HKDF_HMAC256_L32 and method to negate a private key by jonasschnelli)
• #14045 (refactor: Fix the chainparamsbase -> util circular dependency by Empact)
• #14035 (Utxoscriptindex by mgrychow)
• #13815 (util: Add [[nodiscard]] to all {Decode,Parse}... functions returning bool by practicalswift)
• #13751 (Utils and libraries: Drops the boost/algorithm/string/split.hpp dependency by 251Labs)
• #13746 (-masterdatadir for datadir bootstrapping by kallewoof)
• #12677 (RPC: Add ancestor{count,size,fees} to listunspent output by luke-jr)
• #11785 (Raise the open fd limit to the maximum allowed by vii)
• #10443 (Add fee_est tool for debugging fee estimation code by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

IMO scripted diff commit could have the mv commands to avoid having a bad commit.

Could you please apply this as the second commit? Thanks

diff --git a/build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj b/build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj
index 0be7e7e43..2c6c0a8b7 100644
--- a/build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj
+++ b/build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj
@@ -40,7 +40,7 @@
     <ClCompile Include="..\..\src\script\script.cpp" />
     <ClCompile Include="..\..\src\script\script_error.cpp" />
     <ClCompile Include="..\..\src\uint256.cpp" />
-    <ClCompile Include="..\..\src\utilstrencodings.cpp" />
+    <ClCompile Include="..\..\src\util\strencodings.cpp" />
   </ItemGroup>
   <ItemGroup>
     <None Include="packages.config" />

utACK d0f883e9c5c7dd1ac9efcd69eb0065e47376afef

utACK d0f883e, sorry conflicts..

utACK d0f883e9c5c7dd1ac9efcd69eb0065e47376afef

utACK d0f883e

utACK https://github.com/bitcoin/bitcoin/pull/14555/commits/d0f883e9c5c7dd1ac9efcd69eb0065e47376afef After rebase this is probably mergeable

After rebase:

diff --git a/src/base58.cpp b/src/base58.cpp
index eac763394..e3d285339 100644
--- a/src/base58.cpp
+++ b/src/base58.cpp
@@ -6,7 +6,7 @@
 
 #include <hash.h>
 #include <uint256.h>
-#include <utilstrencodings.h>
+#include <util/strencodings.h>
 
 #include <assert.h>
 #include <string.h>

utACK 2068f089c8b7b90eb4557d3f67ea0f0ed2059a23

tACK 2068f08 make check and ran the functional tests.

Might be a good to merge this now, to save the constant rebasing. Doesn't look like this will break any ready to merge/PRs with ACKs etc.

Agree with @fanquake, ACK 2068f08.

utACK 2068f089c8b7b90eb4557d3f67ea0f0ed2059a23

• util/system.h is great naming, yes, the file is for os/system utilities
• We need to come up with guidelines (in the developer notes) what to put in src/compat versus src/support versus src/util, all three are more or less utilities. But that can be done later.