bitcoin client 0.17.0 ignores wallet's name (file) #14523

issue nikitasius opened this issue on October 19, 2018
  1. nikitasius commented at 9:48 PM on October 19, 2018: none

    Old config (version 0.15 and 0.16.0/0.16.3):

    prune=8192
rpcuser=rpc
rpcpassword=rpc
onlynet=ipv4
testnet=1
rpcbind=127.0.0.1:18332
walletdir=/path/to/wallet/
wallet=mywallet.dat

    It worked pretty nice.

    UPD: it does not worked in version 0.17.0 ! BTC client made a new wallet.dat file

    On version 0.17.0 i read what i can use full pathes to wallet files.

    prune=8192
rpcuser=rpc
rpcpassword=rpc
onlynet=ipv4
testnet=1
rpcbind=127.0.0.1:18332
wallet=/path/to/wallet/mywallet.dat

    FAILS. It created wallet.dat in /path/to/wallet/ folder

    prune=8192
rpcuser=rpc
rpcpassword=rpc
onlynet=ipv4
testnet=1
rpcbind=127.0.0.1:18332
walletdir=/path/to/wallet/
wallet=/path/to/wallet/mywallet.dat

    FAILS. It created wallet.dat in ~/.bitcoin/wallets folder.

    Current config:

    prune=8192
rpcuser=rpc
rpcpassword=rpc
onlynet=ipv4
testnet=1
rpcbind=127.0.0.1:18332
walletdir=/path/to/wallet/

    AND i renamed mywallet.dat into wallet.dat to let client work.

    I run bitcoin core client 0.17.0 on Linux 4.9.0-6-amd64 [#1](/github-metadata-backup-bitcoin-bitcoin/1/) SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux.

  2. meshcollider added the label Wallet on Oct 19, 2018
  3. ryanofsky commented at 10:26 PM on October 19, 2018: contributor

    walletdir=/path/to/wallet/ wallet=mywallet.dat It worked pretty nice. UPD: it does not worked in version 0.17.0 ! BTC client made a new wallet.dat file

    I think I'm able to reproduce this. It looks like #11862 might be causing your wallet config argument to be ignored. Do you see this warning?

    Warning: Config setting for -wallet only applied on test network when in [test] section.

    On version 0.17.0 i read what i can use full pathes to wallet files.

    We might need to clarify release notes, but this isn't true. You can only specify full paths to wallet directories not wallet files. (Originally this was possible, but it was deemed too dangerous because it might mislead people into creating incomplete backups of wallets).

  4. nikitasius commented at 5:23 PM on October 20, 2018: none

    @ryanofsky , hi yes:

    grep applied debug.log
2018-10-19T21:04:04Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
2018-10-19T21:04:04Z Warning: Config setting for -wallet only applied on test network when in [test] section.
2018-10-19T21:16:02Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
2018-10-19T21:16:02Z Warning: Config setting for -wallet only applied on test network when in [test] section.
2018-10-19T21:21:35Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
2018-10-19T21:21:35Z Warning: Config setting for -wallet only applied on test network when in [test] section.
2018-10-19T21:23:35Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
2018-10-19T21:23:35Z Warning: Config setting for -wallet only applied on test network when in [test] section.
2018-10-19T21:30:02Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
2018-10-19T21:37:18Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.
2018-10-19T21:37:18Z Warning: Config setting for -wallet only applied on test network when in [test] section.
2018-10-19T21:41:20Z Warning: Config setting for -rpcbind only applied on test network when in [test] section.

    it's same debug.log i keep, records inside are from 14 october. 0.17.0 was installed yesterday.

  5. nikitasius commented at 5:24 PM on October 20, 2018: none

    but why i need (or not) to specity test section inside a config? i.e. i already specified a testnet.

  6. ryanofsky commented at 6:06 PM on October 20, 2018: contributor

    but why i need (or not) to specity test section inside a config? i.e. i already specified a testnet.

    Before #11862 and 0.17.0, you didn't need to have -wallet and other "network-only" options under a network section. Now it looks you need to or they get ignored.

    I think this is a mistake, and we should backport a fix that will restore the old behavior. It don't think it is ok to just start ignoring settings that used to work. We should probably keep the log message to encourage people to use network-specific sections and be more explicit about settings that are sensitive to which network is used, but we should not just be dropping the settings on the floor.

    It also seems like a mistake to me that -wallet is a "network-only" option but -walletdir is not. This is another thing that should probably be addressed.

  7. MarcoFalke added this to the milestone 0.17.1 on Oct 21, 2018
  8. MarcoFalke added the label Bug on Oct 21, 2018
  9. MarcoFalke added the label Utils/log/libs on Oct 21, 2018
  10. MarcoFalke removed the label Wallet on Oct 21, 2018
  11. ryanofsky cross-referenced this on Oct 23, 2018 from issue Network specific conf sections by ajtowns
  12. MarcoFalke removed this from the milestone 0.17.1 on Dec 3, 2018
  13. MarcoFalke added this to the milestone 0.17.2 on Dec 3, 2018
  14. MarcoFalke commented at 6:19 PM on December 3, 2018: member

    Moving to 0.17.2

  15. MarcoFalke removed this from the milestone 0.17.2 on Mar 20, 2019
  16. MarcoFalke added this to the milestone 0.18.1 on Mar 20, 2019
  17. MarcoFalke removed this from the milestone 0.18.1 on Mar 20, 2019
  18. MarcoFalke cross-referenced this on Mar 20, 2019 from issue init: Throw error when network specific config is ignored by MarcoFalke
  19. MarcoFalke commented at 9:21 PM on March 20, 2019: member

    Made it an error instead of warning in #15629, so at least Bitcoin Core wouldn't start with such a config file.

  20. MarcoFalke referenced this in commit 5392aee64f on Apr 10, 2019
  21. MarcoFalke commented at 1:19 AM on April 10, 2019: member

    Should be "fixed" in master

  22. MarcoFalke closed this on Apr 10, 2019
  23. ryanofsky cross-referenced this on Nov 6, 2019 from issue test: Add util_ArgParsing test by ryanofsky
  24. vijaydasmp referenced this in commit 4082cef036 on Oct 15, 2021
  25. vijaydasmp referenced this in commit 0f74ebae16 on Oct 16, 2021
  26. vijaydasmp referenced this in commit 96f2c7d1d3 on Oct 16, 2021
  27. vijaydasmp referenced this in commit 01ec4b3fb6 on Oct 16, 2021
  28. vijaydasmp referenced this in commit 6d8217ed63 on Oct 16, 2021
  29. vijaydasmp referenced this in commit 95e5a21d1e on Oct 16, 2021
  30. vijaydasmp referenced this in commit ca0c5df7f0 on Oct 16, 2021
  31. bitcoin locked this on Dec 16, 2021
Contributors
nikitasiusryanofskyMarcoFalke
Labels
BugUtils/log/libs
Linked (view graph)
#1 JSON-RPC support for mobile devices ("ultra-lightweight" clients)#11687 External wallet files#11862 Network specific conf sections#15629 init: Throw error when network specific config is ignored#17390 test: Add util_ArgParsing test
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:54 UTC