depends: qt: avoid system harfbuzz and bz2 #14385

pull theuni wants to merge 1 commits into bitcoin:master from theuni:freetype-depends changing 2 files +2 −1
  1. theuni commented at 8:53 PM on October 3, 2018: member

    Should fix #14367.

    Gitian builds end up with this config implicitly due to missing harfbuzz system lib, this change explicitly disables the use of the lib completely, even if present.

    We may eventually want to break out harfbuzz and build it in depends, but for now just ensure that runtime dependencies don't depend on whether or not harfbuzz was present on the builder. @real-or-random Can you confirm that this fixes your issue?

  2. depends: qt: avoid system harfbuzz and bz2
    We may eventually want to break out harfbuzz and build it in depends, but
for now just ensure that runtime dependencies don't depend on whether or not
harfbuzz was present on the builder.
    f149e31ea2
  3. MarcoFalke added the label Needs gitian build on Oct 3, 2018
  4. fanquake added the label Build system on Oct 3, 2018
  5. DrahtBot commented at 3:26 AM on October 4, 2018: contributor

    <!--32850dd3fdea838b4049e64f46995ea2-->

    Coverage Change (pull 14385) Reference (master)
    Lines +0.0419 % 86.9985 %
    Functions -0.0154 % 84.1902 %
    Branches +0.0398 % 51.5024 %
  6. real-or-random commented at 11:58 AM on October 4, 2018: contributor

    Thanks, this fixes the build for me. :+1:

    (But I can't judge how bad this affects users for which harfbuzz works currently.)

  7. DrahtBot commented at 10:16 PM on October 4, 2018: contributor

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 1f59c6f3eb6c2d5b8dcff04dc3334ee0f0de5b17 (master):

    Gitian builds for commit afaea21ac6980fb09750e76cb327430a84899355 (master and this pull):

  8. DrahtBot removed the label Needs gitian build on Oct 4, 2018
  9. bitcoin deleted a comment on Oct 4, 2018
  10. ken2812221 commented at 4:16 PM on October 6, 2018: contributor

    utACK f149e31ea2f28b72dbc3e7d7a8fe31466eabef85

  11. fanquake commented at 8:16 AM on October 8, 2018: member

    utACK f149e31

    This upstream ticket also partially explains what happened (I haven't tracked down the actual commit). Basically, from 5.8.0, Qt overhauled its build system, and now defaults to -system-harfbuzz.

    Also discussed with @theuni, and in any case we definitely don't want to be pulling in system harfbuzz, so making this explicit is better.

  12. MarcoFalke merged this on Oct 8, 2018
  13. MarcoFalke closed this on Oct 8, 2018
  14. MarcoFalke referenced this in commit 4de0b5f39c on Oct 8, 2018
  15. Bushstar cross-referenced this on Oct 11, 2018 from issue Updates from bitcoin/master by Bushstar
  16. bitcoin deleted a comment on Oct 13, 2018
  17. unknown cross-referenced this on Feb 28, 2019 from issue Backport bitcoin#14385: qt: avoid system harfbuzz and bz2 by ghost
  18. UdjinM6 referenced this in commit 080b59a573 on Mar 1, 2019
  19. PastaPastaPasta referenced this in commit de14aa5a34 on Mar 10, 2019
  20. koad referenced this in commit 49746de943 on Oct 9, 2020
  21. bitcoin locked this on Sep 8, 2021
Contributors
theuniDrahtBotreal-or-randomken2812221fanquake
Labels
Build system
Linked (view graph)
#14367 [depends] freetype 2.7.1 requires specific harfbuzz version
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC