Since #14247
we do check for duplicate inputs in CheckBlock #14257
pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:checkblock_check_dup changing 1 files +0 −1-
instagibbs commented at 3:36 PM on September 18, 2018: member
-
we do check for duplicate inputs in CheckBlock e02500aa55
-
- DrahtBot cross-referenced this on Sep 18, 2018 from issue Remove redundant parameter fCheckDuplicateInputs from CheckTransaction(...) by practicalswift
-
DrahtBot commented at 5:46 PM on September 18, 2018: contributor
<!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:
- #14258 (Remove redundant parameter fCheckDuplicateInputs from CheckTransaction(...) by practicalswift)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- MarcoFalke closed this on Sep 18, 2018
-
instagibbs commented at 7:29 PM on September 18, 2018: member
@MarcoFalke subsumed by #14258 or?
-
MarcoFalke commented at 7:32 PM on September 18, 2018: member
Indeed, looks like #14258 is doing a similar thing.
-
jeffrade commented at 12:31 AM on September 20, 2018: contributor
This is a popular bug fix. I was curious and was about to submit the same PR :laughing:
- instagibbs cross-referenced this on Sep 27, 2018 from issue Trivial: update comment in CheckTransaction #14247 by brouwerQ
- promag cross-referenced this on Nov 28, 2018 from issue remove fCheckDuplicateInputs by 3s3s
- bitcoin locked this on Sep 8, 2021
