[0.16] Fix crash bug with duplicate inputs within a transaction #14249

1. 
   TheBlueMatt commented at 10:00 PM on September 17, 2018: contributor

   This is a backport of #14247 to 0.16.

2. Fix crash bug with duplicate inputs within a transaction

   Introduced by #9049

   d1dee20547
3. [qa] backport: Test for duplicate inputs within a transaction 9bd08fd465
4. fanquake added this to the milestone 0.16.x on Sep 17, 2018
5. fanquake added the label Bug on Sep 17, 2018
6. laanwj added the label Consensus on Sep 17, 2018
7. 
   sdaftuar commented at 10:27 PM on September 17, 2018: member

   ACK

8. 
   TheBlueMatt commented at 10:36 PM on September 17, 2018: contributor

   Travis failure is mkdir: cannot create directory ‘/home/travis/build/bitcoin/bitcoin/depends/built/x86_64-unknown-linux-gnu/native_ccache’: Permission denied which is pretty clearly unrelated, though not sure exactly what the issue is. I presume some cache has garbage in it.

9. 
   MarcoFalke commented at 10:38 PM on September 17, 2018: member

   Don't worry about the travis issue. The cache is corrupt for months on that branch.

10. 
    MarcoFalke commented at 10:44 PM on September 17, 2018: member

    utACK d1dee205473140aca34180e5de8b9bbe17c2207d. The first commit is a clean cherry-pick, haven't looked at the test changes too closely.

11. laanwj merged this on Sep 17, 2018
12. laanwj closed this on Sep 17, 2018

    ---

13. laanwj referenced this in commit 696b936aa3 on Sep 17, 2018
14. mmitech cross-referenced this on Sep 19, 2018 from issue Fix crash bug with duplicate inputs within a transaction (TheBlueMatt… by mmitech
15. Bushstar cross-referenced this on Sep 22, 2018 from issue Updates from Bitcoin 0.16.2 - 0.16.3 by Bushstar
16. gruve-p referenced this in commit 25bca4a6ba on Sep 22, 2018
17. gruve-p referenced this in commit 275cc370ba on Sep 22, 2018
18. litebitcoins referenced this in commit c8a6477564 on Sep 23, 2018
19. litebitcoins referenced this in commit 43a1aa6f1c on Sep 23, 2018
20. leafcutterant cross-referenced this on Sep 24, 2018 from issue Is ElectrumX affected by the Bitcoin Core DDoS + inflation bug? by leafcutterant
21. Lesmiscore referenced this in commit 82912b508f on Sep 25, 2018
22. Lesmiscore cross-referenced this on Sep 25, 2018 from issue [z2.0.x] Fix crash bug with duplicate inputs within a transaction by Lesmiscore
23. Lesmiscore referenced this in commit 6e751d19f1 on Sep 25, 2018
24. Lesmiscore cross-referenced this on Sep 25, 2018 from issue [z3.x] Fix crash bug with duplicate inputs within a transaction by Lesmiscore
25. mempko cross-referenced this on Sep 26, 2018 from issue Check for duplicate inputs during block check. by mempko
26. Greg-Griffith referenced this in commit 5c4fa78b79 on Sep 26, 2018
27. Greg-Griffith referenced this in commit 9bf9550e88 on Sep 26, 2018
28. gandrewstone referenced this in commit 905d04b2c6 on Oct 2, 2018
29. bitcoin locked this on Sep 8, 2021

Contributors

TheBlueMattsdaftuarMarcoFalke

Milestone
0.16.x