[0.17][psbt] always drop the unnecessary utxo and convert non-witness utxo to witness when necessary #14196

1. 
   achow101 commented at 3:52 AM on September 11, 2018: member

   When we sign an input in a psbt that has a non-witness utxo but a witness signature is produced, we will now replace the non-witness utxo with the corresponding witness utxo. Furthermore, we should make sure that the correct UTXO type is used based on what UTXOs are there, not based on earlier wallet behavior.

   Note that this is PR'd to the 0.17 branch because the code here no longer exists in master.

2. fanquake added this to the milestone 0.17.0 on Sep 11, 2018
3. fanquake added the label Wallet on Sep 11, 2018
4. Drop the unnecessary UTXO based on the UTXOs present, not on earlier wallet things

   Instead of dropping the unnecessary UTXO based on whether the wallet did something,
   do it based on whether two UTXOs are there.

   fcdea8ad2a
5. Convert non-witness UTXOs to witness if witness sig created

   If a witness signature was created when a non-witness UTXO is used,
   convert the non-witness UTXO to a witness one.

   fcefc6851a
6. achow101 force-pushed on Sep 11, 2018
7. achow101 cross-referenced this on Sep 11, 2018 from issue [psbt] Convert non-witness UTXOs to witness if witness sig created by achow101
8. 
   fanquake commented at 5:21 AM on September 11, 2018: member

   Test failure seemed unrelated, rebooted Travis.

9. 
   gmaxwell commented at 4:01 AM on September 13, 2018: contributor

   This sounds right to me.

10. 
    gmaxwell commented at 4:48 PM on September 14, 2018: contributor

    ACK

11. 
    araspitzu commented at 12:07 PM on September 19, 2018: none

    Would it be possible to add a test for this?

12. MarcoFalke removed this from the milestone 0.17.0 on Sep 30, 2018
13. MarcoFalke added this to the milestone 0.17.1 on Sep 30, 2018
14. 
    MarcoFalke commented at 1:12 AM on September 30, 2018: member

    Moved to 0.17.1 for now, because this can be worked around and psbt isn't considered final in the 0.17.0 release.

15. laanwj referenced this in commit f6df989842 on Nov 1, 2018
16. 
    meshcollider commented at 12:10 PM on November 10, 2018: contributor

    utACK https://github.com/bitcoin/bitcoin/pull/14196/commits/fcefc6851a624b59bd1bb42d211ce69f85969880

17. 
    sipa commented at 3:13 AM on November 11, 2018: member

    utACK fcefc6851a624b59bd1bb42d211ce69f85969880

18. MarcoFalke merged this on Dec 1, 2018
19. MarcoFalke closed this on Dec 1, 2018

    ---

20. MarcoFalke referenced this in commit 3362a95be3 on Dec 1, 2018
21. bitcoin locked this on Dec 16, 2021

Contributors

achow101fanquakegmaxwellaraspitzuMarcoFalkemeshcollidersipa

Milestone
0.17.1