Refactor SelectCoinsMinConf() and add unit tests #1416

pull luke-jr wants to merge 5 commits into bitcoin:master from luke-jr:refactor_coinselect changing 3 files +437 −83

luke-jr commented at 4:55 PM on June 4, 2012: member

AvailableCoins() makes a vector of available outputs which is then passed to SelectCoinsMinConf(). This allows unit tests to test the coin selection algorithm without having the whole blockchain available.

This is an updated (with changes made in #1017, but not Coin Control itself) and rebased form of #905.

Refactor SelectCoinsMinConf() and add unit tests.

AvailableCoins() makes a vector of available outputs which is then passed to SelectCoinsMinConf().  This allows unit tests to test the coin selection algorithm without having the whole blockchain available.

9b0369c773

Move the random_shuffle call back into SelectCoinsMinConf() so we can unit test it. e333ab56d5
Test that the coin selection code is suitably random, and add tests re. sub-cent change. 4ce190a015
Preserve the shuffled order of coins with equal value to give more randomized coin selection. d650f96d5f
Fix coin selection to only include change when it's necessary. 831f59ce8b
luke-jr cross-referenced this on Jun 4, 2012 from issue Coin Control by luke-jr
gavinandresen commented at 12:06 AM on June 5, 2012: contributor

ACK. It makes ./test_bitcoin spew tons of "best subset" messages, but that's not your fault.
luke-jr cross-referenced this on Jun 12, 2012 from issue Don't create change when it isn't necessary. by dooglus
luke-jr cross-referenced this on Jun 12, 2012 from issue coin control / less change / refactor coin selection by dooglus
sipa commented at 11:43 AM on June 13, 2012: member

ACK
gavinandresen commented at 1:35 AM on June 14, 2012: contributor

ACK
gavinandresen merged this on Jun 14, 2012
gavinandresen closed this on Jun 14, 2012
lateminer referenced this in commit 06abba7a14 on Jan 22, 2019
lateminer referenced this in commit be6f1279b6 on May 6, 2020
bitcoin locked this on Sep 8, 2021

Contributors

luke-jr

gavinandresen

sipa

Linked (view graph)

#898 Don't create change when it isn't necessary.#905 Refactor SelectCoinsMinConf() and add unit tests.#1017 coin control / less change / refactor coin selection #1359 Coin Control