Alternative to #13724
The ideal solution is probably somewhere in between.
Symbol checks for ARM and RISC-V #14065
pull luke-jr wants to merge 4 commits into bitcoin:master from luke-jr:symbol_check changing 2 files +58 −20-
luke-jr commented at 1:34 AM on August 26, 2018: member
-
symbol-check: Fix readelf output parsing fa1ce9f8d3
-
symbol-check: Command-line options to configure checks 6eac7f6986
-
gitian-linux: Use check-symbols for ARM ef19d36378
-
gitian-linux: Use check-symbols for RISC-V 8b03a40e6c
- fanquake added the label Scripts and tools on Aug 26, 2018
- luke-jr cross-referenced this on Aug 26, 2018 from issue gitian-linux: Build binaries for 64-bit POWER by luke-jr
-
DrahtBot commented at 4:26 AM on August 26, 2018: contributor
<!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:
- #14091 (Minor style enhacement in documentation by fedsten)
- #13724 ([contrib] Support ARM and RISC-V symbol check by ken2812221)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Aug 26, 2018 from issue [contrib] Support ARM and RISC-V symbol check by ken2812221
-
laanwj commented at 8:53 AM on August 27, 2018: member
Please, do we really need competing PRs for this?
At least explain in more detail what the difference is, and why!
-
luke-jr commented at 9:30 AM on August 27, 2018: member
Put this together before I saw the other one.
This one uses command line options to define what is acceptable, and has gitian provide them per arch. The other one hard-codes stuff all over the place.
- DrahtBot cross-referenced this on Aug 29, 2018 from issue Minor style enhancement in documentation by fedsten
- MarcoFalke added the label Build system on Aug 31, 2018
- MarcoFalke added the label Needs gitian build on Aug 31, 2018
-
DrahtBot commented at 3:55 PM on August 31, 2018: contributor
<!--cf906140f33d8803c4a75a2196329ecb-->Needs rebase
- DrahtBot added the label Needs rebase on Aug 31, 2018
- DrahtBot removed the label Needs gitian build on Sep 1, 2018
- luke-jr closed this on Sep 1, 2018
- bitcoin deleted a comment on Sep 4, 2018
- laanwj removed the label Needs rebase on Oct 24, 2019
- bitcoin locked this on Dec 16, 2021
