Empact
commented at 10:23 AM on August 23, 2018:
member
std::is_trivially_constructible<T> is equivalent to std::is_trivially_default_constructible<T>std::has_trivial_default_constructor<T> is the GCC < 5 name for std::is_trivially_default_constructible<T>
std::is_trivial was also used when compiling with clang, due to clang's use of __GNUC__. Test __clang__ to target the intended implementations.
https://stackoverflow.com/a/28166605
All callers currently only pass one template argument to IS_TRIVIALLY_CONSTRUCTIBLE, with this change the build would fail if someone attempted passing more.
fanquake added the label Refactoring on Aug 23, 2018
Empact force-pushed on Aug 23, 2018
Make IS_TRIVIALLY_CONSTRUCTIBLE consistent on GCC < 5
std::is_trivially_constructible<T> is equivalent to std::is_trivially_default_constructible<T>
std::has_trivial_default_constructor<T> is the GCC < 5 name for std::is_trivially_default_constructible<T>
std::is_trivial was also used when compiling with clang, due to clang's use of __GNUC__. Test __clang__
to target the intended implementations.
f1640d093f
Empact force-pushed on Aug 23, 2018
Empact renamed this: Make IS_TRIVIALLY_CONSTRUCTIBLE consistent on GCC < 5 Make IS_TRIVIALLY_CONSTRUCTIBLE consistent on GCC < 5, don't patch clang on Aug 23, 2018
laanwj
commented at 9:39 AM on August 27, 2018:
member
ACKf1640d093fa682c98b000e377916cc32b2267e23
Tested on gcc 4.8.4.
laanwj merged this on Aug 27, 2018
laanwj closed this on Aug 27, 2018
laanwj referenced this in commit cb98effc5c on Aug 27, 2018
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC