This removes the #include <boost/signals2/signal.hpp> from util.h (hopefully speeding up the build time and reducing the memory usage further after #13634)
The whole translation interface is replaced by a function G_TRANSLATION_FUN that is set to nullptr in units that don't need translation. (Thus only set in the gui)
For all bitcoind units that depend on util:
(gcc default ./configure)
Excellent!
Concept ACK
<!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
utACK fa7db59
49 | - 50 | extern const char * const BITCOIN_CONF_FILENAME; 51 | extern const char * const BITCOIN_PID_FILENAME; 52 | 53 | +/** Translate a message to the native language of the user. */ 54 | +const extern std::function<std::string(const char*)>* G_TRANSLATION_FUN;
How about
const extern std::function<std::string(const char*)> G_TRANSLATION_FUN;
And below (L51) use https://en.cppreference.com/w/cpp/utility/functional/function/operator_bool?
Done
utACK ddddce0e46e73d4ca369f2ce9696231cc579e1f9
12 | @@ -13,6 +13,8 @@ 13 | 14 | #include <memory> 15 | 16 | +const std::function<std::string(const char*)> G_TRANSLATION_FUN = nullptr;
These = nullptr are not needed since it's not a pointer and the empty constructor has the same behaviour.