[qa] Add test for max number of entries in locator #13915

1. 
   MarcoFalke commented at 8:48 PM on August 8, 2018: member

   Should not be merged before #13907

2. MarcoFalke added the label Tests on Aug 8, 2018
3. 
   MarcoFalke commented at 8:48 PM on August 8, 2018: member

   Thanks for @jnewbery providing early feedback.

4. in test/functional/p2p_invalid_locator.py:26 in fa310aeb0f outdated

     21 | +
     22 | +        self.log.info('Test max locator size')
     23 | +        block_count = node.getblockcount()
     24 | +        for msg in [msg_getheaders(), msg_getblocks()]:
     25 | +            self.log.info('Wait for disconnect when sending {} hashes in locator'.format(MAX_LOCATOR_SZ + 1))
     26 | +            node.add_p2p_connection(P2PInterface())
   

   ---

   ---

   

   jnewbery commented at 9:03 PM on August 8, 2018:

   Sorry, I was unclear in my comment previously. We still need to call wait_for_verack(). What I meant was that we should move that call up into P2PInterface.peer_connect() (a bit like the current send_version argument).

5. 
   jnewbery commented at 9:05 PM on August 8, 2018: member

   One comment inline. Otherwise looks great.

6. MarcoFalke cross-referenced this on Aug 8, 2018 from issue qa: wait_for_verack by default by MarcoFalke
7. 
   jnewbery commented at 9:44 PM on August 8, 2018: member

   Tested ACK fa310aeb0fb1840cf5197057fad6ed376e7c8ec3 ~(assuming #13916 goes in, otherwise I think node connection in this is racy)~

   EDIT: 13916 is merged. Unqualified tested ACK :grin:

8. 
   DrahtBot commented at 10:47 PM on August 9, 2018: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->No more conflicts as of last run.

9. DrahtBot cross-referenced this on Aug 9, 2018 from issue Introduce a maximum size for locators. by gmaxwell
10. in test/functional/test_framework/messages.py:35 in fa310aeb0f outdated

      31 | @@ -32,6 +32,7 @@
      32 |  MY_RELAY = 1 # from version 70001 onwards, fRelay should be appended to version messages (BIP37)
      33 |  
      34 |  MAX_INV_SZ = 50000
      35 | +MAX_LOCATOR_SZ = 64
    

    ---

    ---

    

    MarcoFalke commented at 2:36 PM on August 10, 2018:

    Need to be adjusted before merge!

11. DrahtBot added the label Needs rebase on Aug 10, 2018
12. qa: Add p2p_invalid_locator test fa85c985ed
13. MarcoFalke force-pushed on Aug 10, 2018
14. 
    MarcoFalke commented at 6:10 PM on August 10, 2018: member

    Force pushed new version. Only change should be 64->101

15. MarcoFalke added this to the milestone 0.17.0 on Aug 10, 2018
16. 
    achow101 commented at 6:52 PM on August 10, 2018: member

    ACK fa85c985edbfd297aefb613445deab37c8769753

17. DrahtBot removed the label Needs rebase on Aug 10, 2018
18. 
    sipa commented at 10:37 PM on August 10, 2018: member

    Concept ACK

19. 
    gmaxwell commented at 10:01 AM on August 11, 2018: contributor

    ACK

20. MarcoFalke merged this on Aug 11, 2018
21. MarcoFalke closed this on Aug 11, 2018

    ---

22. MarcoFalke referenced this in commit a04888a075 on Aug 11, 2018
23. MarcoFalke deleted the branch on Aug 11, 2018
24. Bushstar cross-referenced this on Aug 13, 2018 from issue commits from bitcoin/master by Bushstar
25. Fuzzbawls cross-referenced this on Mar 16, 2020 from issue [Net] Max block locator entries size. by furszy
26. UdjinM6 referenced this in commit 7a4c891884 on Jul 4, 2021
27. UdjinM6 referenced this in commit c70e3cf126 on Jul 6, 2021
28. UdjinM6 referenced this in commit 290a23a9e4 on Jul 6, 2021
29. bitcoin locked this on Sep 8, 2021

Contributors

MarcoFalkejnewberyDrahtBotachow101sipagmaxwell

Milestone
0.17.0