Log progress while verifying blocks at level 4 #13910

pull domob1812 wants to merge 1 commits into bitcoin:master from domob1812:progress changing 1 files +8 −2
  1. domob1812 commented at 11:23 AM on August 8, 2018: contributor

    When verifying blocks at startup, the progress is printed in 10% increments to logs. When -checklevel=4, however, the second half of the verification (connecting the blocks again) does not log the progress anymore. (It is still computed and shown in the UI, but not printed to logs.)

    This change makes the behaviour consistent, by adding the missing progress logging also for level-4 checks.

  2. Log progress while verifying blocks at level 4.
    When verifying blocks at startup, the progress is printed in 10%
    increments to logs.  When -checklevel=4, however, the second half
    of the verification (connecting the blocks again) does not log the
    progress anymore.  (It is still computed and shown in the UI, but
    not printed to logs.)
    
    This change makes the behaviour consistent, by adding the missing
    progress logging also for level-4 checks.
    e58985c916
  3. luke-jr approved
  4. luke-jr commented at 9:06 PM on August 27, 2018: member

    utACK

  5. DrahtBot cross-referenced this on Oct 20, 2018 from issue refactor: Drop boost::thread and boost::chrono by ken2812221
  6. DrahtBot commented at 10:41 AM on October 20, 2018: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  7. MarcoFalke commented at 11:09 AM on October 20, 2018: member

    utACK e58985c916fda39b8ccf08d0db00426af939749a

  8. domob1812 commented at 7:25 AM on January 4, 2019: contributor

    Friendly ping - anything I should do to get this merged?

  9. MarcoFalke renamed this:
    Trivial: Log progress while verifying blocks at level 4
    Log progress while verifying blocks at level 4
    on Jan 4, 2019
  10. MarcoFalke referenced this in commit 9c64278e1a on Jan 4, 2019
  11. MarcoFalke merged this on Jan 4, 2019
  12. MarcoFalke closed this on Jan 4, 2019

  13. domob1812 deleted the branch on Jan 4, 2019
  14. jasonbcox referenced this in commit face1dda03 on Jul 8, 2020
  15. PastaPastaPasta referenced this in commit 2109946c2d on Jun 26, 2021
  16. PastaPastaPasta referenced this in commit 63e47c42a5 on Jun 28, 2021
  17. bitcoin locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC