Filename and command line encoding issue on Windows #13869

1. 
   ken2812221 commented at 7:09 PM on August 3, 2018: contributor

   This issue tracks the TODO list in order to fix the encoding issue on Window.

   Currently Bitcoin Core uses the ANSI encoding on Windows so that it would affected by user's language settings, they might not able to open some non-ASCII name files.

   You can test all these changes in #13787 (includes leveldb changes)

   Open PRs:

   • Package the Windows installer in unicode mode (NSIS 3+) (#13827, Up for grab, or wait for Ubuntu 20.04 gitian builder host)

   Merged PRs:

   • Create the startup shortcut file in unicode mode (#13734)
   • Make filelock work on unicode filename (#13862)
   • Use _wfopen instead of fopen on Windows to pass unicode filename (#13866)
   • Make boost fs::path .string() to be always encoded to utf-8 (#13877)
   • Wrap ifstream and ofstream to accept unicode filename. (#13878)
   • Get the command line arguments using unicode (#13883)
   • Make bdb read the filename using utf-8 (#13884)
   • Make runCommand works on unicode filename (#13886)
   • Convert all (...)A function to (...)W on Windows if it is related to filename or command line. (#13888)
   • Convert boost filesystem error messages from local multibyte to utf-8 (#14192)
   • Make leveldb read the filename using utf-8 (bitcoin-core/leveldb#18)
2. ken2812221 renamed this:
   Encoding issue on Windows
   Filenam encoding issue on Windows
   on Aug 3, 2018
3. ken2812221 renamed this:
   Filenam encoding issue on Windows
   Filename encoding issue on Windows
   on Aug 3, 2018
4. fanquake added the label Windows on Aug 4, 2018
5. fanquake added this to the milestone 0.18.0 on Aug 4, 2018
6. ken2812221 cross-referenced this on Aug 5, 2018 from issue Test for Windows encoding issue by ken2812221
7. DrahtBot cross-referenced this on Aug 5, 2018 from issue -masterdatadir for datadir bootstrapping by kallewoof
8. DrahtBot cross-referenced this on Aug 5, 2018 from issue refactor: Replace boost::bind with std::bind by ken2812221
9. DrahtBot cross-referenced this on Aug 5, 2018 from issue bitcoin-cli: -stdinwalletpassphrase and non-echo stdin passwords by kallewoof
10. DrahtBot cross-referenced this on Aug 5, 2018 from issue Check for datadir after the config files were read by Flowdalic
11. DrahtBot cross-referenced this on Aug 5, 2018 from issue travis: Enable qt for all jobs by ken2812221
12. DrahtBot cross-referenced this on Aug 5, 2018 from issue utils: Make fs::path::string() always return utf-8 string on Windows by ken2812221
13. ken2812221 renamed this:
    Filename encoding issue on Windows
    Filename and command line encoding issue on Windows
    on Aug 6, 2018
14. ken2812221 cross-referenced this on Aug 6, 2018 from issue Use utf-8 to decode filename by ken2812221
15. DrahtBot cross-referenced this on Aug 6, 2018 from issue [WIP] depends: Add native_nsis to support unicode by ken2812221
16. DrahtBot cross-referenced this on Aug 10, 2018 from issue utils: Add fstream wrapper to allow to pass unicode filename on Windows by ken2812221
17. DrahtBot cross-referenced this on Aug 10, 2018 from issue utils: Use _wfopen and _wfreopen on Windows by ken2812221
18. DrahtBot cross-referenced this on Aug 10, 2018 from issue utils: drop boost::interprocess::file_lock by ken2812221
19. DrahtBot cross-referenced this on Aug 14, 2018 from issue ~~Correctly~~ terminate HTTP server by promag
20. DrahtBot cross-referenced this on Aug 15, 2018 from issue refactor: use fs:: over boost::filesystem:: by fanquake
21. MarcoFalke cross-referenced this on Aug 15, 2018 from issue preparation for support windows 98 ? or what is it by alexeyneu
22. 
    ken2812221 commented at 7:44 PM on August 30, 2018: contributor

    @sipsorcery @NicolasDorier Mind take a look at this?

23. 
    NicolasDorier commented at 2:05 AM on August 31, 2018: contributor

    Amazing work, ye.

24. ken2812221 cross-referenced this on Sep 5, 2018 from issue tests: Run functional test on Windows and enable it on Appveyor by ken2812221
25. ken2812221 cross-referenced this on Jan 4, 2019 from issue cyrillic/unicode issue requires daemon/QT to be run as admin. by xaya
26. laanwj referenced this in commit f545dfabff on Jan 26, 2019
27. ken2812221 closed this on Jan 31, 2019

    ---

28. Warrows cross-referenced this on Sep 13, 2019 from issue Working with international accounts names on windows by sepavel
29. Warrows cross-referenced this on Oct 15, 2019 from issue [Utils] Fix windows utf8 paths by Warrows
30. Fuzzbawls cross-referenced this on Jan 30, 2021 from issue [GUI] Use wchar_t API explicitly on Windows by Fuzzbawls
31. random-zebra referenced this in commit f15a1674ce on Feb 6, 2021
32. furszy cross-referenced this on Jun 24, 2021 from issue Solve filename and command line encoding issues on Windows by furszy
33. random-zebra referenced this in commit 61a098a775 on Aug 5, 2021
34. bitcoin locked this on Dec 16, 2021

Contributors

ken2812221NicolasDorier

Milestone
0.18.0