Bugfixes for BIP 174 combining and deserialization #13721

1. 
   achow101 commented at 2:06 AM on July 20, 2018: member

   This PR fixes a few bugs that were found and adds tests checking for these errors.

   Specifically:

   • Single byte keys are checked to actually be one byte.
   • Unknown global data must be merged when combining two PSBTs.
2. Check that PSBT keys are the correct length

   Checks that all of the one byte type keys are actually one byte and
   throw an error if they are not.
   
   Add tests for each type to check for this behavior.

   41df035ee1
3. Fix merging of global unknown data in PSBTs

   Actually merge the global unknown key-value pairs.
   
   Add a test for merging unknown key-value pairs.

   fad231ad41
4. fanquake added this to the milestone 0.17.0 on Jul 20, 2018
5. 
   practicalswift commented at 11:22 AM on July 20, 2018: contributor

   Concept ACK

   Thanks for taking another look at this code

6. laanwj added the label Bug on Jul 20, 2018
7. 
   sipa commented at 10:48 PM on July 20, 2018: member

   utACK fad231ad41e12b7047deb64220942ca8cb8357bc

8. 
   Christewart commented at 12:25 AM on July 24, 2018: contributor

   If there are still serialization questions here it might be worth testing with #12775 / #8469

9. fanquake added this to the "Blockers" column in a project

---

10. 
    laanwj commented at 1:03 PM on July 25, 2018: member

    utACK fad231ad41e12b7047deb64220942ca8cb8357bc

11. laanwj merged this on Jul 25, 2018
12. laanwj closed this on Jul 25, 2018

    ---

13. laanwj referenced this in commit 9f23c16599 on Jul 25, 2018
14. fanquake removed this from the "Blockers" column in a project

---

15. Bushstar cross-referenced this on Aug 13, 2018 from issue commits from bitcoin/master by Bushstar
16. kwvg referenced this in commit c2739e073a on Jun 4, 2021
17. kwvg referenced this in commit 209c0fedc4 on Jun 4, 2021
18. kwvg cross-referenced this on Jun 4, 2021 from issue merge #13269, #13425, #13557, #13721, #13666, #13723: BIP 174 PSBT Serializations and RPCs by kwvg
19. UdjinM6 referenced this in commit 26d282c321 on Jun 7, 2021
20. barrystyle referenced this in commit acb122e6cf on Jun 8, 2021
21. barrystyle referenced this in commit 9166796714 on Jun 8, 2021
22. kwvg referenced this in commit de1e0a5cfd on Jun 9, 2021
23. kwvg referenced this in commit be39cc9d7c on Jul 9, 2021
24. kwvg referenced this in commit a6dbdcbd56 on Jul 13, 2021
25. kwvg referenced this in commit 34116d17d1 on Jul 13, 2021
26. kwvg referenced this in commit 737ccd2de3 on Jul 13, 2021
27. PastaPastaPasta referenced this in commit e98241da5d on Jul 13, 2021
28. bitcoin locked this on Sep 8, 2021

Contributors

achow101practicalswiftsipaChristewartlaanwj

Milestone
0.17.0