This adds light functional coverage to estimaterawfee - a subset of the testing applied to estimatesmartfee, and argument validation testing to both estimaterawfee and estimatesmartfee.
One valid estimatesmartfee signature test is commented out because it fails currently.
Extracted from #12940
8 | + - estimatesmartfee 9 | + - estimaterawfee 10 | +""" 11 | + 12 | +from test_framework.test_framework import BitcoinTestFramework 13 | +from test_framework.util import *
Avoid wildcard imports :-)
Concept ACK modulo removal of wildcard imports :-)
Removed wildcard imports. Thanks!
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
No conflicts as of last run.
103 | +def check_raw_estimates(node, fees_seen): 104 | + """Call estimaterawfee and verify that the estimates meet certain invariants.""" 105 | + 106 | + delta = 1.0e-6 # account for rounding error 107 | + for i in range(1, 26): 108 | + for time_horizon, e in node.estimaterawfee(i).items():
Nit: for _, e in node.estimaterawfee(i).items():
Done 👍
<!--5d09a71f8925f3f132321140b44b946d-->The last travis run for this pull request was 277 days ago and is thus outdated. To trigger a fresh travis build, this pull request should be closed and re-opened.
This adds light functional coverage to estimaterawfee - a subset of
the testing applied to estimatesmartfee, and argument validation
testing to both estimaterawfee and estimatesmartfee.
One valid estimatesmartfee signature test is commented out because it
fails currently.
Rebased, dropped unused reference in test
re-run ci