wallet: Fix backupwallet for multiwallets #13667

1. 
   domob1812 commented at 9:20 AM on July 15, 2018: contributor

   backupwallet was broken for multiwallets in their own directories (i.e. something like DATADIR/wallets/mywallet/wallet.dat). In this case, the backup would use DATADIR/wallets/wallet.dat as source file and not take the specific wallet's directory into account.

   This led to either an error during the backup (if the wrong source file was not present) or would silently back up the wrong wallet; especially the latter behaviour can be quite bad for users.

2. domob1812 cross-referenced this on Jul 15, 2018 from issue backupwallet fails with multi wallet by domob1812
3. fanquake added the label Wallet on Jul 15, 2018
4. wallet: Fix backupwallet for multiwallets

   backupwallet was broken for multiwallets in their own directories
   (i.e. something like DATADIR/wallets/mywallet/wallet.dat).  In this
   case, the backup would use DATADIR/wallets/wallet.dat as source file
   and not take the specific wallet's directory into account.
   
   This led to either an error during the backup (if the wrong source
   file was not present) or would silently back up the wrong wallet;
   especially the latter behaviour can be quite bad for users.

   a1a998cf24
5. domob1812 force-pushed on Jul 15, 2018
6. 
   MarcoFalke commented at 4:04 PM on July 15, 2018: member

   Would this require backport to the 0.16 branch?

7. 
   promag commented at 4:05 PM on July 15, 2018: member

   utACK a1a998c. No travis?

8. 
   domob1812 commented at 4:57 PM on July 15, 2018: contributor

   I think that 0.16 does not yet support multiwallets in their own subdirectories, does it? Then it would not require a backport.

9. 
   MarcoFalke commented at 9:27 PM on July 15, 2018: member

   Thanks, just wanted to ask for clarity.

10. domob1812 referenced this in commit 89951e00cf on Jul 16, 2018
11. 
    DrahtBot commented at 11:20 AM on July 16, 2018: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->No more conflicts as of last run.

12. DrahtBot cross-referenced this on Jul 16, 2018 from issue [bugfix] Fix encoding issue for Windows by ken2812221
13. DrahtBot cross-referenced this on Jul 25, 2018 from issue [WIP] Full unicode support on Windows by ken2812221
14. DrahtBot cross-referenced this on Jul 28, 2018 from issue Test for Windows encoding issue by ken2812221
15. 
    domob1812 commented at 4:06 PM on August 5, 2018: contributor

    Is there anything I need to do here?

16. MarcoFalke added this to the milestone 0.17.0 on Aug 5, 2018
17. 
    laanwj commented at 11:31 AM on August 7, 2018: member

    utACK a1a998cf24c0cf1232e44ec8eaf2ad6875ab5153

18. laanwj merged this on Aug 7, 2018
19. laanwj closed this on Aug 7, 2018

    ---

20. laanwj referenced this in commit b81a8a5ea9 on Aug 7, 2018
21. domob1812 deleted the branch on Aug 7, 2018
22. 
    Hary2511 commented at 5:22 PM on August 7, 2018: none

    What should I do here

23. Bushstar cross-referenced this on Aug 13, 2018 from issue commits from bitcoin/master by Bushstar
24. jasonbcox referenced this in commit 903f7859b4 on Dec 20, 2019
25. jonspock referenced this in commit b58a0ad875 on Oct 2, 2020
26. jonspock referenced this in commit fa0b8eb8cb on Oct 5, 2020
27. jonspock referenced this in commit 0101347c8a on Oct 10, 2020
28. PastaPastaPasta referenced this in commit d8bdd210a1 on Feb 2, 2021
29. PastaPastaPasta referenced this in commit 58965e41ea on Feb 4, 2021
30. UdjinM6 referenced this in commit 10ec1200d9 on Jun 30, 2021
31. UdjinM6 referenced this in commit a77d944408 on Jul 1, 2021
32. UdjinM6 referenced this in commit 7a2a63ef34 on Jul 2, 2021
33. UdjinM6 referenced this in commit 0214211a7f on Jul 2, 2021
34. bitcoin locked this on Sep 8, 2021

Contributors

domob1812MarcoFalkepromagDrahtBotlaanwjHary2511

Milestone
0.17.0