Log warning when deprecated network name 'tor' is used #13532

pull ghost wants to merge 1 commits into bitcoin:master from changing 1 files +5 −1

ghost commented at 8:36 PM on June 24, 2018: none

As @laanwj mentioned here, using option onlynet=tor is deprecated.

I think it would be good to give the user a depcreaction warning feedback, so users can switch to onlynet=onion so there is a perspective for removing the deprecated tor in the future to decrease confusion.

Currently, users maybe just wonder that they can use a undocumented option, or they are not aware that they use a deprecated option.

Alternatively for the log warning message, I think at least this deprecetaion should be documented in the source code in a comment for readers of the source code.
Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor) 9f8c54b1b5
unknown cross-referenced this on Jun 24, 2018 from issue Docs: More precise explanation of parameter onlynet by ghost
fanquake added the label P2P on Jun 24, 2018
laanwj commented at 3:44 PM on June 25, 2018: member

utACK 9f8c54b1b5ddedddf47fc51c1fcb533321f6f89f
sipa commented at 6:53 PM on June 25, 2018: member

utACK 9f8c54b1b5ddedddf47fc51c1fcb533321f6f89f
promag commented at 3:11 PM on June 26, 2018: member

utACK 9f8c54b.

Makes sense to s/NET_TOR/NET_ONION/?
jb55 approved
jb55 commented at 7:53 PM on June 26, 2018: contributor

ACK 9f8c54b1b5ddedddf47fc51c1fcb533321f6f89f
sipa commented at 11:39 PM on June 26, 2018: member

utACK 9f8c54b1b5ddedddf47fc51c1fcb533321f6f89f
laanwj merged this on Jun 27, 2018
laanwj closed this on Jun 27, 2018
laanwj referenced this in commit 7209fec190 on Jun 27, 2018
Bushstar cross-referenced this on Jun 28, 2018 from issue commits from bitcoin/master by Bushstar
unknown deleted the branch on Jun 30, 2018
unknown cross-referenced this on Jun 30, 2018 from issue Refactor: Rename NET_TOR to NET_ONION by ghost
laanwj referenced this in commit 5c05dd6285 on Jul 4, 2018
jonatack cross-referenced this on May 17, 2019 from issue netbase: Remove "tor" as a network specification by dongcarl
PastaPastaPasta referenced this in commit 33787241d5 on Apr 16, 2020
PastaPastaPasta referenced this in commit 89815fa2c8 on Apr 16, 2020
PastaPastaPasta referenced this in commit bb02ff1774 on Apr 19, 2020
PastaPastaPasta referenced this in commit 1b6227ad3d on Apr 20, 2020
PastaPastaPasta referenced this in commit 45aef679d0 on May 10, 2020
PastaPastaPasta referenced this in commit 674ad86c32 on May 12, 2020
PastaPastaPasta referenced this in commit 0f7f679c14 on Jun 9, 2020
PastaPastaPasta referenced this in commit d0c2101736 on Jun 9, 2020
PastaPastaPasta referenced this in commit c018c32753 on Jun 10, 2020
PastaPastaPasta referenced this in commit 889e0bf276 on Jun 11, 2020
furszy cross-referenced this on Jun 7, 2021 from issue Road to Tor v3 support (BIP155) by furszy
gades referenced this in commit 6087f72d15 on Jun 25, 2021
furszy cross-referenced this on Jul 15, 2021 from issue [Net] asmap to improve IP bucketing in addrman - backports by furszy
random-zebra referenced this in commit 85f000ecbe on Jul 30, 2021
random-zebra referenced this in commit b4751e10ce on Aug 11, 2021
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#13418 Docs: More precise explanation of parameter onlynet #13575 Refactor: Rename NET_TOR to NET_ONION #16029 netbase: Remove "tor" as a network specification