[tests] Fix p2p_sendheaders race #13522

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:p2p_sendheaders_race changing 1 files +2 −0

jnewbery commented at 3:59 PM on June 22, 2018: member

p2p_sendheaders has a race in part 1.3.

part 1.2 sends a block to the node over the 'test_node' connection, but doesn't wait for an inv to be received on the 'inv_node' connection. If we get to part 1.3 before that inv has been received, then the subsequent call to check_last_inv_announcement could fail.

[tests] Fix p2p_sendheaders race

p2p_sendheaders has a race in part 1.3.

part 1.2 sends a block to the node over the 'test_node' connection, but
doesn't wait for an inv to be received on the 'inv_node' connection. If
we get to part 1.3 before that inv has been received, then the
subsequent call to check_last_inv_announcement could fail.

75848bcf40

jnewbery cross-referenced this on Jun 22, 2018 from issue [qa] mininode: Expose connection state through is_connected by MarcoFalke
fanquake added the label Tests on Jun 22, 2018
MarcoFalke commented at 4:44 PM on June 22, 2018: member

utACK 75848bcf401a23672aaec1d8be2738443946808c
fanquake commented at 8:35 AM on July 1, 2018: member

utACK 75848bc
MarcoFalke merged this on Jul 1, 2018
MarcoFalke closed this on Jul 1, 2018
MarcoFalke referenced this in commit 686e97a0c7 on Jul 1, 2018
Bushstar cross-referenced this on Jul 2, 2018 from issue commits from bitcoin/master by Bushstar
jnewbery deleted the branch on Jul 2, 2018
dsaveliev cross-referenced this on Mar 10, 2019 from issue Fix p2p_sendheaders race by dsaveliev
scravy referenced this in commit ea638d67f7 on Mar 11, 2019
codablock referenced this in commit af97ea2242 on Apr 18, 2020
codablock cross-referenced this on Apr 18, 2020 from issue Backport #13522: [tests] Fix p2p_sendheaders race by codablock
UdjinM6 referenced this in commit 08477899b4 on Apr 19, 2020
ckti referenced this in commit a4c7c851a8 on Mar 28, 2021
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#13512 [qa] mininode: Expose connection state through is_connected