[wallet] Decouple wallet version from client version #13500

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:decouple-wallet-version changing 2 files +3 −3

achow101 commented at 10:31 PM on June 18, 2018: member

Instead of comparing version numbers in the wallet to the client version number, compare them to the latest supported wallet version in the client. This allows for wallet version numbers to be unrelated to the client version number.

Decouple wallet version from client version

Instead of comparing version numbers in the wallet to the client
version number, compare them to the latest supported wallet version
in the client. This allows for wallet version numbers to be unrelated
to the client version number.

cd3f4aa808

fanquake added the label Wallet on Jun 18, 2018
MarcoFalke commented at 5:54 AM on June 19, 2018: member

Thanks, should make testing new wallet features with master (.99 versions) a lot easier, i.e. not breaking dev's wallets.
DrahtBot commented at 10:38 PM on June 19, 2018: contributor
Note to reviewers: This pull request conflicts with the following ones:
- #12992 ([wallet] Add wallet name to log messages by PierreRochard)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
meshcollider commented at 1:47 AM on June 22, 2018: contributor

LGTM
sipa commented at 2:17 AM on June 22, 2018: member

utACK cd3f4aa80810fc077c7f9528a4ef53c1438c86e1
instagibbs commented at 7:11 PM on July 11, 2018: member

little mystified why this wasn't already done, thanks

utACK https://github.com/bitcoin/bitcoin/pull/13500/commits/cd3f4aa80810fc077c7f9528a4ef53c1438c86e1
fanquake commented at 1:20 PM on July 15, 2018: member

utACK cd3f4aa
laanwj commented at 6:59 PM on July 18, 2018: member

utACK cd3f4aa80810fc077c7f9528a4ef53c1438c86e1
laanwj merged this on Jul 18, 2018
laanwj closed this on Jul 18, 2018
laanwj referenced this in commit 4a3e8c5aa6 on Jul 18, 2018
Bushstar cross-referenced this on Jul 19, 2018 from issue commits from bitcoin/master by Bushstar
sipa cross-referenced this on Jul 19, 2018 from issue Net: Bucketing INV delays (1 bucket) for incoming connections to hide tx time by naumenkogs
sipa cross-referenced this on Jul 19, 2018 from issue [wallet] Add wallet name to log messages by PierreRochard
jasonbcox referenced this in commit cb35659a7f on Dec 20, 2019
PastaPastaPasta referenced this in commit c8c56670a5 on Jul 19, 2020
PastaPastaPasta referenced this in commit 42a45daad0 on Jul 24, 2020
PastaPastaPasta referenced this in commit 937e1224a2 on Jul 27, 2020
UdjinM6 referenced this in commit 8a26ec1b2d on Jul 27, 2020
UdjinM6 referenced this in commit 76561e849e on Jul 27, 2020
bitcoin locked this on Sep 8, 2021