Drop ParseHashUV in favor of calling ParseHashStr #13422

pull Empact wants to merge 1 commits into bitcoin:master from Empact:parse-hash-uv changing 3 files +1 −10
  1. Empact commented at 5:54 PM on June 8, 2018: member

    The one existing call already validates get_str will pass via checkObject: https://github.com/bitcoin/bitcoin/pull/13422/files#diff-8fe4d6985ee4acf8bfc1ed8db1e83cb5L586

    Split from #13420

  2. Drop ParseHashUV in favor of calling ParseHashStr
    The one existing call already validates get_str will
    pass via checkObject.
    abd2678ac1
  3. MarcoFalke commented at 6:18 PM on June 8, 2018: member

    utACK abd2678ac1af10f55b8b29507407c9e286e06f09

  4. Empact commented at 12:54 AM on June 9, 2018: member

    7 hours without a tag and I'm worried for the health and safety of @fanquake. :P

  5. fanquake added the label Refactoring on Jun 9, 2018
  6. Empact commented at 1:23 AM on June 9, 2018: member

    Glad you're still with us! ;)

  7. promag commented at 1:45 PM on June 10, 2018: member

    utACK abd2678.

  8. DrahtBot commented at 8:27 PM on June 14, 2018: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:

    • #13399 (rpc: Add submitblockheader by MarcoFalke)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  9. DrahtBot cross-referenced this on Jun 14, 2018 from issue rpc: Add submitheader by MarcoFalke
  10. sipa commented at 1:02 AM on June 15, 2018: member

    utACK abd2678ac1af10f55b8b29507407c9e286e06f09

  11. MarcoFalke merged this on Jun 15, 2018
  12. MarcoFalke closed this on Jun 15, 2018

  13. MarcoFalke referenced this in commit 2b770080a4 on Jun 15, 2018
  14. Bushstar cross-referenced this on Jun 15, 2018 from issue commits from bitcoin/master by Bushstar
  15. Empact deleted the branch on Jul 2, 2018
  16. MarcoFalke cross-referenced this on Sep 21, 2018 from issue rest: Do not re-use the function name ParseHashStr (core_io.h) for a function with different behaviour in rest.cpp by practicalswift
  17. PastaPastaPasta referenced this in commit 1c002dd1b6 on Jul 7, 2020
  18. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC