All the other operators are integer or bitwise operations, and this is unused apart from tests.
Note attempting to call ! on arith_uint256 results in a build error after this change:
test/arith_uint256_tests.cpp:201:17: error: invalid argument type 'const arith_uint256' to unary expression
BOOST_CHECK(!ZeroL);
All the other operators are integer or bit operations, and this is unused
apart from tests.
utACK 2acd1d6.
Isn't ! expected functionality for bigint arithmetic? I'm aware that we're not using it at the moment, but I'd like to invoke the principle of least surprise here
When was it last used?
It's a function in the include file, so I would even doubt this affect the binary size. Also ti's properly tested so that can't be an argument to remove it either. I'd say NACK, sorry.
<!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
My motivation is to reduce lines of code because I view unused functionality as a tax on readers of the code, even if those lines don't impact the binaries. I guess you could say this is partly an expression of the YAGNI principle.
Oke, forget my argument about API symmetry. There is no operator bool() on arith_uint256, so why would bool operator!() exist. This means you can do if (!a) but not if(a). Hmm.
utACK 2acd1d6716959b99e751cf85a7c47aaa383e937f
utACK 2acd1d6716959b99e751cf85a7c47aaa383e937f
