build: Guard against accidental introduction of new Boost dependencies #13385

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:lint-boost changing 1 files +68 −0
  1. practicalswift commented at 6:50 PM on June 3, 2018: contributor

    Guard against accidental introduction of new Boost dependencies.

    Context: #13383 – the usage of boost::lexical_cast was introduced in #11517 from December 2017

  2. practicalswift force-pushed on Jun 3, 2018
  3. practicalswift force-pushed on Jun 3, 2018
  4. practicalswift force-pushed on Jun 3, 2018
  5. fanquake added the label Scripts and tools on Jun 4, 2018
  6. laanwj commented at 6:50 AM on June 4, 2018: member

    nothing else to say here

    utACK e4191d3419ee4ccda0a611632a859e72c40e7ca4

  7. practicalswift force-pushed on Jun 4, 2018
  8. practicalswift force-pushed on Jun 4, 2018
  9. build: Guard against accidental introduction of new Boost dependencies 81bbd32a2c
  10. practicalswift force-pushed on Jun 4, 2018
  11. practicalswift commented at 8:11 AM on June 4, 2018: contributor

    Updated version: Removed boost/lexical_cast.hpp from EXPECTED_BOOST_INCLUDES now that #13383 has been merged. Added logic that notifies the operator when a previous dependency has been removed, asking for an update of EXPECTED_BOOST_INCLUDES. @laanwj Please re-review :-)

  12. promag commented at 9:47 AM on June 4, 2018: member

    Concept ACK.

  13. DrahtBot commented at 2:53 PM on June 4, 2018: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->Note to reviewers: This pull request conflicts with the following ones:

    • #13230 (Simplify include analysis by enforcing the developer guide's include syntax)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  14. practicalswift commented at 3:01 PM on June 4, 2018: contributor

    @DrahtBot I'll simply rebase once one of them is merged :-)

  15. bitcoin deleted a comment on Jun 4, 2018
  16. MarcoFalke commented at 3:08 PM on June 4, 2018: member

    utACK 81bbd32a2c755482c6e8ef049a59de672715b545

  17. Empact commented at 9:36 AM on June 5, 2018: member

    Concept ACK

  18. laanwj merged this on Jun 5, 2018
  19. laanwj closed this on Jun 5, 2018
  20. laanwj referenced this in commit 7c7508c268 on Jun 5, 2018
  21. Bushstar cross-referenced this on Jun 6, 2018 from issue commits from bitcoin/master by Bushstar
  22. Empact cross-referenced this on Jun 6, 2018 from issue lint: Add linter to error on #include <*.cpp> by Empact
  23. PastaPastaPasta referenced this in commit 3301b73c37 on Jun 17, 2020
  24. PastaPastaPasta referenced this in commit 9a9aa3f467 on Jul 2, 2020
  25. str4d cross-referenced this on Oct 27, 2020 from issue Backport useful lints from upstream by str4d
  26. zkbot referenced this in commit 43ac2062f9 on Oct 28, 2020
  27. zkbot referenced this in commit 84a5830aaa on Nov 9, 2020
  28. practicalswift deleted the branch on Apr 10, 2021
  29. Fuzzbawls cross-referenced this on Feb 7, 2022 from issue [Lint] Introduce lint-includes.sh script by Fuzzbawls
  30. random-zebra referenced this in commit 0e757ad2c9 on Feb 9, 2022
  31. gades referenced this in commit 2dddfcabda on Feb 21, 2022
  32. bitcoin locked this on Aug 18, 2022
Contributors
practicalswiftlaanwjpromagDrahtBotMarcoFalkeEmpact
Labels
Scripts and tools
Linked (view graph)
#11517 Tests: Improve benchmark precision#13301 lint: Add linter to error on #include <*.cpp>#13383 bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...)
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:54 UTC