Fix "gmake check" under OpenBSD 6.3 (probably *BSD): Avoid using GNU grep specific regexp handling #13355

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:openbsd-gmake-check changing 1 files +2 −2
  1. practicalswift commented at 8:32 AM on May 31, 2018: contributor

    Fixes #13337 (!)

    GNU grep and BSD grep differs in the way they handle regexps when extended regular expressions are not enabled via the -E flag:

    $ grep --version | head -1
    grep (GNU grep) 3.1
    $ echo "BOOST_FIXTURE_TEST_SUITE(foo)" | grep "BOOST_FIXTURE_TEST_SUITE(\|BOOST_AUTO_TEST_SUITE("
    BOOST_FIXTURE_TEST_SUITE(foo)
    $
    
    $ grep --version | head -1
    grep version 0.9
    $ echo "BOOST_FIXTURE_TEST_SUITE(foo)" | grep "BOOST_FIXTURE_TEST_SUITE(\|BOOST_AUTO_TEST_SUITE("
    $ 
    

    The portable way to do it is:

    $ echo "BOOST_FIXTURE_TEST_SUITE(foo)" | grep -E "(BOOST_FIXTURE_TEST_SUITE\\(|BOOST_AUTO_TEST_SUITE\\()"
    BOOST_FIXTURE_TEST_SUITE(foo)
    $
    
  2. Fix "gmake check" under OpenBSD 6.3 (probably *BSD): Avoid using GNU grep specific regexp handling db56755ca4
  3. practicalswift cross-referenced this on May 31, 2018 from issue OpenBSD 6.3 build: test/arith_uint256_tests.cpp complains about missing argument by grim-trigger
  4. fanquake added the label Linux/Unix on May 31, 2018
  5. laanwj commented at 8:42 AM on May 31, 2018: member

    utACK db56755ca4a0e53785b5bf322d3b65ffe328b60a

    (can we get a Tested ACK from you @grim-trigger?)

  6. grim-trigger commented at 12:06 AM on June 1, 2018: contributor

    Tested ACK db56755

    Works fine on OpenBSD 6.3/AMD64

  7. MarcoFalke added the label Tests on Jun 1, 2018
  8. MarcoFalke removed the label Linux/Unix on Jun 1, 2018
  9. MarcoFalke added the label Linux/Unix on Jun 1, 2018
  10. MarcoFalke removed the label Linux/Unix on Jun 1, 2018
  11. fanquake commented at 8:04 AM on June 1, 2018: member

    tACK db56755 on OpenBSD 6.3

  12. laanwj merged this on Jun 1, 2018
  13. laanwj closed this on Jun 1, 2018

  14. laanwj referenced this in commit 0b1c0c462e on Jun 1, 2018
  15. practicalswift cross-referenced this on Jun 6, 2018 from issue Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 by practicalswift
  16. Bushstar cross-referenced this on Jun 6, 2018 from issue commits from bitcoin/master by Bushstar
  17. markblundeberg commented at 12:55 AM on July 3, 2019: none

    (cf #12926)

  18. practicalswift deleted the branch on Apr 10, 2021
  19. UdjinM6 referenced this in commit e3b4051be8 on Jun 19, 2021
  20. UdjinM6 referenced this in commit 39959fc7ef on Jun 24, 2021
  21. UdjinM6 referenced this in commit 168ad2644e on Jun 26, 2021
  22. UdjinM6 referenced this in commit f76c320a26 on Jun 26, 2021
  23. PastaPastaPasta referenced this in commit 0072ea2988 on Jun 27, 2021
  24. PastaPastaPasta referenced this in commit f8a7e1bd24 on Jun 28, 2021
  25. PastaPastaPasta referenced this in commit e4aa0e6200 on Jun 28, 2021
  26. UdjinM6 referenced this in commit dbb0c39f93 on Jun 28, 2021
  27. PastaPastaPasta referenced this in commit 05c1b67d25 on Jun 29, 2021
  28. bitcoin locked this on Aug 18, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC