refactor: privatize SignatureExtractorChecker [moveonly] #13266

pull Empact wants to merge 1 commits into bitcoin:master from Empact:data-from-transaction changing 1 files +10 −13
  1. Empact commented at 12:14 AM on May 18, 2018: member

    ~If we add a CTxIn constructor to SignatureData, then constructing the SignatureData directly is no more verbose than calling DataFromTransaction, and grants the caller additional flexibiliy in how to provide the CTxIn.~

    A simple change to enhance encapsulation.

  2. fanquake added the label Refactoring on May 18, 2018
  3. promag commented at 12:17 AM on May 18, 2018: member

    utACK 61f178b.

  4. MarcoFalke added the label Needs rebase on Jun 6, 2018
  5. Empact force-pushed on Jun 6, 2018
  6. Empact commented at 9:24 AM on June 6, 2018: member

    Rebased for #13269

  7. MarcoFalke removed the label Needs rebase on Jun 6, 2018
  8. DrahtBot cross-referenced this on Jun 14, 2018 from issue Moving final scriptSig construction from CombineSignatures to ProduceSignature (PSBT signer logic) by achow101
  9. DrahtBot cross-referenced this on Jun 28, 2018 from issue BIP 174 PSBT Serializations and RPCs by achow101
  10. Empact force-pushed on Jul 6, 2018
  11. Empact renamed this:
    refactoring: Inline DataFromTransaction via new SignatureData constructor
    refactoring: Convert DataFromTransaction to a SignatureData constructor, privatize and drop dead code from helpers
    on Jul 6, 2018
  12. Empact commented at 4:12 AM on July 6, 2018: member

    ~This has developed into a bit of a follow-up on #13425. @achow101 would you take a look?~

  13. Empact force-pushed on Jul 11, 2018
  14. Empact cross-referenced this on Jul 11, 2018 from issue Drop dead code from Stacks by Empact
  15. Empact renamed this:
    refactoring: Convert DataFromTransaction to a SignatureData constructor, privatize and drop dead code from helpers
    refactoring: Convert DataFromTransaction to a SignatureData constructor, and privatize helpers
    on Jul 11, 2018
  16. in src/script/sign.h:73 in 1f85582219 outdated 
      69 | @@ -70,6 +70,8 @@ struct SignatureData {
  70 |  
  71 |      SignatureData() {}
  72 |      explicit SignatureData(const CScript& script) : scriptSig(script) {}
  73 | +    explicit SignatureData(const CMutableTransaction& tx, unsigned int nIn, const CTxOut& txout);
    sipa commented at 8:54 PM on July 14, 2018:

    I would prefer to keep SignatureData independent from the data being signed.

  17. Empact force-pushed on Jul 15, 2018
  18. Empact renamed this:
    refactoring: Convert DataFromTransaction to a SignatureData constructor, and privatize helpers
    refactoring: privatize SignatureExtractorChecker
    on Jul 15, 2018
  19. Empact force-pushed on Jul 15, 2018
  20. sipa commented at 7:27 AM on July 17, 2018: member

    utACK 4012fe1be85ee00d55951a5bb69bd451159a9ea0

  21. DrahtBot added the label Needs rebase on Jul 18, 2018
  22. Empact force-pushed on Jul 19, 2018
  23. Empact commented at 4:53 AM on July 19, 2018: member

    Rebased for #13557

  24. DrahtBot removed the label Needs rebase on Jul 20, 2018
  25. DrahtBot cross-referenced this on Aug 27, 2018 from issue Implement sighash cache in CHECKMULTISIG by jl2012
  26. MarcoFalke commented at 6:08 PM on September 7, 2018: member

    utACK a0a0df379519bef6db33f69ed668d9c251d0dfe7

  27. MarcoFalke closed this on Sep 7, 2018
  28. MarcoFalke reopened this on Sep 7, 2018
  29. DrahtBot cross-referenced this on Sep 7, 2018 from issue [Policy] Reject SIGHASH_SINGLE with output out of bound by jl2012
  30. DrahtBot commented at 6:54 PM on September 7, 2018: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #13360 ([Policy] Reject SIGHASH_SINGLE with output out of bound by jl2012)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  31. Empact renamed this:
    refactoring: privatize SignatureExtractorChecker
    [moveonly] privatize SignatureExtractorChecker
    on Jan 17, 2019
  32. DrahtBot added the label Needs rebase on Feb 14, 2019
  33. Make SignatureExtractorChecker private to its own file
    It's only used here in DataFromTransaction
    73aaf4ecf8
  34. Empact force-pushed on Mar 4, 2019
  35. Empact commented at 9:21 AM on March 4, 2019: member

    Rebased. git show --color-moved=dimmed_zebra --color-moved-ws=allow-indentation-change eases review.

  36. DrahtBot removed the label Needs rebase on Mar 4, 2019
  37. MarcoFalke commented at 8:46 PM on March 4, 2019: member

    utACK 73aaf4ecf825a4d18c802ca5dd3856ce9096915e

  38. Empact commented at 2:30 PM on June 5, 2019: member

    This has 3 utACKs, 1 current.

    2 conflicting PRs: #14079: no ACKs #13360: 1 concept ACK

  39. laanwj renamed this:
    [moveonly] privatize SignatureExtractorChecker
    refactor: privatize SignatureExtractorChecker [moveonly]
    on Oct 2, 2019
  40. laanwj commented at 10:11 AM on October 2, 2019: member

    ACK 73aaf4ecf825a4d18c802ca5dd3856ce9096915e

  41. laanwj referenced this in commit 752debdbdb on Oct 2, 2019
  42. laanwj merged this on Oct 2, 2019
  43. laanwj closed this on Oct 2, 2019
  44. sidhujag referenced this in commit 2eacb4a7b6 on Oct 2, 2019
  45. deadalnix referenced this in commit 1fd789f3de on Oct 24, 2020
  46. PastaPastaPasta referenced this in commit eb4aa4955a on Sep 11, 2021
  47. PastaPastaPasta referenced this in commit 1adb39076b on Sep 11, 2021
  48. PastaPastaPasta referenced this in commit c549bb7bff on Sep 12, 2021
  49. PastaPastaPasta referenced this in commit 4ce8dc25c5 on Sep 12, 2021
  50. PastaPastaPasta referenced this in commit 87cb7358fe on Sep 12, 2021
  51. PastaPastaPasta referenced this in commit f010f439bb on Sep 14, 2021
  52. PastaPastaPasta referenced this in commit 5d1c9453e0 on Sep 14, 2021
  53. PastaPastaPasta referenced this in commit 8a3389e88e on Sep 15, 2021
  54. bitcoin locked this on Dec 16, 2021
Contributors
EmpactpromagsipaMarcoFalkeDrahtBotlaanwj
Labels
Refactoring
Linked (view graph)
#13269 refactoring: Drop UpdateTransaction in favor of UpdateInput#13425 Moving final scriptSig construction from CombineSignatures to ProduceSignature (PSBT signer logic)#13557 BIP 174 PSBT Serializations and RPCs#13633 Drop dead code from Stacks
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:54 UTC