wallet: Fix ReserveKeyFromKeyPool to always test key classification, even if last in the pool. #13257

pull Empact wants to merge 1 commits into bitcoin:master from Empact:fix-reserve-key-classification-check changing 1 files +3 −2

Empact commented at 5:03 AM on May 17, 2018: member

In the prior code set_pre_split_keypool's size is sampled before and after the removal, so when the last key is being reserved, it previously would not apply the "keypool entry misclassified" test.

Fix CWallet::ReserveKeyFromKeyPool to always test key classification

Even if last in the pool. In the prior code set_pre_split_keypool's size is
sampled before and after the removal, so when the last key is being reserved,
it previously would not apply the "keypool entry misclassified" test.

a730bd5900

Empact cross-referenced this on May 17, 2018 from issue Wallet: Refactor ReserveKeyFromKeyPool for safety by Empact
Empact commented at 5:06 AM on May 17, 2018: member

Nevermind. The set sampled is not the one modified in this case. Not a bug. :P
Empact closed this on May 17, 2018
Empact deleted the branch on May 17, 2018
bitcoin locked this on Sep 8, 2021

Contributors

Empact

Linked (view graph)

#13252 Wallet: Refactor ReserveKeyFromKeyPool for safety