[net] Don't incorrectly log that REJECT messages are unknown. #13162

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:fix_reject_logging changing 1 files +1 −0

jnewbery commented at 5:42 PM on May 3, 2018: member
Reject messages are logged to debug.log if NET debug logging is enabled.

Because of the way the ProcessMessages() function is structured, processing for REJECT messages will also drop through to the default branch and incorrectly log Unknown command "reject" from peer-?. Fix that by exiting from ProcessMessages() early.

without this PR:
```
2018-05-03T17:37:00.930600Z received: reject (21 bytes) peer=0
2018-05-03T17:37:00.930620Z Reject message code 16: spammy spam
2018-05-03T17:37:00.930656Z Unknown command "reject" from peer=0
```
with this PR:
```
2018-05-03T17:35:04.751246Z received: reject (21 bytes) peer=0
2018-05-03T17:35:04.751274Z Reject message code 16: spammy spam
```

[logging] Don't incorrectly log that REJECT messages are unknown.

Reject messages are logged to debug.log if NET debug logging is enabled.

Because of the way the `ProcessMessages()` function is structured,
processing for REJECT messages will also drop through to the default
branch and incorrectly log `Unknown command "reject" from peer-?`. Fix
that by exiting from `ProcessMessages()` early.

without this PR:
```
2018-05-03T17:37:00.930600Z received: reject (21 bytes) peer=0
2018-05-03T17:37:00.930620Z Reject message code 16: spammy spam
2018-05-03T17:37:00.930656Z Unknown command "reject" from peer=0
```
with this PR:
```
2018-05-03T17:35:04.751246Z received: reject (21 bytes) peer=0
2018-05-03T17:35:04.751274Z Reject message code 16: spammy spam
```

fad63ebe0f

laanwj added the label P2P on May 3, 2018
MarcoFalke commented at 5:48 PM on May 3, 2018: member

utACK fad63ebe0f0db1e1d909064665be91ebd970bb0a
practicalswift commented at 5:51 PM on May 3, 2018: contributor

utACK fad63ebe0f0db1e1d909064665be91ebd970bb0a

Nice cleanup
laanwj commented at 7:46 PM on May 3, 2018: member

utACK fad63ebe0f0db1e1d909064665be91ebd970bb0a
MarcoFalke renamed this:
~~[logging] Don't incorrectly log that REJECT messages are unknown.~~
[net] Don't incorrectly log that REJECT messages are unknown.
on May 3, 2018
MarcoFalke commented at 9:06 PM on May 3, 2018: member

Changed label to [net], since this reworks the control flow and fixes the logging as side effect.
sdaftuar commented at 4:20 PM on May 4, 2018: member

ACK
Empact commented at 4:57 PM on May 6, 2018: member

utACK fad63eb nit: would be nice to document the role of the return val
laanwj merged this on May 7, 2018
laanwj closed this on May 7, 2018
laanwj referenced this in commit a174702bad on May 7, 2018
Bushstar cross-referenced this on May 8, 2018 from issue commits from bitcoin/master by Bushstar
MarcoFalke cross-referenced this on Aug 12, 2018 from issue p2p: Clarify control flow in ProcessMessage by MarcoFalke
jnewbery deleted the branch on Aug 24, 2018
laanwj referenced this in commit 021dce935a on Aug 25, 2018
PastaPastaPasta referenced this in commit c261173669 on Jan 25, 2020
UdjinM6 referenced this in commit 0ab00ec12f on Jan 28, 2020
PastaPastaPasta referenced this in commit 5cc46c34ca on Jan 28, 2020
UdjinM6 referenced this in commit 31066138c0 on Jan 31, 2020
UdjinM6 referenced this in commit d22cd7da9a on Jan 31, 2020
UdjinM6 referenced this in commit e5e3572e9d on Feb 3, 2020
UdjinM6 referenced this in commit 8d5fc6e0ab on Feb 3, 2020
MIPPL referenced this in commit 3311e33aa0 on May 15, 2020
FornaxA referenced this in commit fa74145cee on Jul 6, 2020
FornaxA referenced this in commit e49789232c on Jul 6, 2020
ckti referenced this in commit 77002d0909 on Mar 28, 2021
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#13946 p2p: Clarify control flow in ProcessMessage