[rpc] nit: fix typo for entry description string #13109

pull mryandao wants to merge 1 commits into bitcoin:master from mryandao:fix-getrawmempool-fee-representation changing 1 files +1 −1

mryandao commented at 6:59 AM on April 28, 2018: contributor

#12240
fanquake added the label Docs on Apr 28, 2018
fanquake added the label RPC/REST/ZMQ on Apr 28, 2018
mryandao cross-referenced this on Apr 28, 2018 from issue [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BTC by mryandao
promag commented at 7:46 AM on April 28, 2018: member

ACK
fanquake approved
fanquake commented at 9:45 AM on April 28, 2018: member

utACK 18dee67

in src/rpc/blockchain.cpp:376 in 18dee67f21 outdated

 372 | @@ -373,7 +373,7 @@ std::string EntryDescriptionString()
 373 |             "        \"base\" : n,         (numeric) transaction fee in " + CURRENCY_UNIT + "\n"
 374 |             "        \"modified\" : n,     (numeric) transaction fee with fee deltas used for mining priority in " + CURRENCY_UNIT + "\n"
 375 |             "        \"ancestor\" : n,     (numeric) modified fees (see above) of in-mempool ancestors (including this one) in " + CURRENCY_UNIT + "\n"
 376 | -           "        \"descendent\" : n,   (numeric) number of in-mempool ancestor transactions (including this one) in " + CURRENCY_UNIT + "\n"
 377 | +           "        \"descendent\" : n,   (numeric) number of in-mempool descendent transactions (including this one) in " + CURRENCY_UNIT + "\n"

MarcoFalke commented at 1:12 PM on April 28, 2018:

GetModFeesWithDescendants has nothing to do with the number of transactions, it returns a fee.

mryandao force-pushed on Apr 28, 2018
mryandao force-pushed on Apr 30, 2018
nit: fix typo for entry description string f7c414daa9
mryandao force-pushed on Apr 30, 2018
jonasschnelli commented at 8:14 AM on April 30, 2018: contributor

utACK f7c414daa980efc3d7aa5255a706e9c18b680694
fanquake commented at 8:43 AM on April 30, 2018: member

re-ACK f7c414d
laanwj commented at 8:50 AM on April 30, 2018: member

utACK, the field is indeed called "descendant" not "descendent" f7c414daa980efc3d7aa5255a706e9c18b680694
laanwj merged this on Apr 30, 2018
laanwj closed this on Apr 30, 2018
laanwj referenced this in commit 219970524d on Apr 30, 2018
Bushstar cross-referenced this on Apr 30, 2018 from issue commits from bitcoin/master by Bushstar
jasonbcox referenced this in commit a6851819dd on Oct 11, 2019
jonspock referenced this in commit 703ea346f6 on Dec 27, 2019
jonspock referenced this in commit 27aa16c638 on Dec 29, 2019
UdjinM6 referenced this in commit 616549fd02 on May 21, 2021
UdjinM6 referenced this in commit 9a6855a050 on May 25, 2021
TheArbitrator referenced this in commit 957457f8a7 on Jun 4, 2021
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#12240 [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BTC