Output values for "min relay fee not met" error #13032

pull kristapsk wants to merge 1 commits into bitcoin:master from kristapsk:min-relay-fee-not-met-debug changing 2 files +2 −2

kristapsk commented at 11:55 PM on April 19, 2018: contributor

It is already done this way for "mempool min fee not met" error.
Output values for "min relay fee not met" error 1accfbcf46
laanwj commented at 3:45 PM on April 23, 2018: member

utACK 1accfbcf465db19a9482d2ba129a66ded316f46e
Empact commented at 10:35 PM on April 23, 2018: member

utACK 1accfbc
laanwj added the label Mempool on Apr 24, 2018
laanwj merged this on Apr 24, 2018
laanwj closed this on Apr 24, 2018
laanwj referenced this in commit 34dd1a6d5e on Apr 24, 2018
MarcoFalke cross-referenced this on Apr 24, 2018 from issue Rewrite the interface between validation and net_processing wrt DoS by TheBlueMatt
Bushstar cross-referenced this on Apr 25, 2018 from issue commits from bitcoin/master by Bushstar

in test/functional/mining_prioritisetransaction.py:123 in 1accfbcf46

 119 | @@ -120,7 +120,7 @@ def run_test(self):
 120 |          tx_id = self.nodes[0].decoderawtransaction(tx_hex)["txid"]
 121 |  
 122 |          # This will raise an exception due to min relay fee not being met
 123 | -        assert_raises_rpc_error(-26, "min relay fee not met (code 66)", self.nodes[0].sendrawtransaction, tx_hex)
 124 | +        assert_raises_rpc_error(-26, "min relay fee not met, 0 < 134 (code 66)", self.nodes[0].sendrawtransaction, tx_hex)

MarcoFalke commented at 5:49 PM on April 25, 2018:

Please don't hardcode 134, as it will change all the time. Either calc the size or use a regex or something

https://travis-ci.org/bitcoin/bitcoin/jobs/371168622#L6011

MarcoFalke commented at 5:52 PM on April 25, 2018:

See 55f89da1a5048cf275c37bceef664e7c04831a35

kristapsk commented at 7:39 PM on April 25, 2018:

Ok, thanks, will look into this!

kristapsk deleted the branch on Apr 25, 2018
kristapsk cross-referenced this on Apr 25, 2018 from issue Tests: don't test against min relay fee information in mining_prioritisetransaction.py by kristapsk
MarcoFalke referenced this in commit 24106a85b3 on Apr 26, 2018
PastaPastaPasta referenced this in commit 908ee2b106 on Nov 10, 2020
PastaPastaPasta referenced this in commit 4baf0b8a02 on Nov 12, 2020
PastaPastaPasta referenced this in commit 971e9a9eb4 on Nov 17, 2020
PastaPastaPasta referenced this in commit 1f9bf1c7cc on Nov 17, 2020
PastaPastaPasta referenced this in commit 16a4608347 on Nov 17, 2020
deadalnix referenced this in commit 25b6d91103 on Nov 28, 2020
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#11639 Rewrite the interface between validation and net_processing wrt DoS #13082 Tests: don't test against min relay fee information in mining_prioritisetransaction.py