[wallet] ScanforWalletTransactions should mark input txns as dirty #12944

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:scandirty changing 2 files +5 −5
  1. instagibbs commented at 1:30 PM on April 11, 2018: member

    I'm hitting a corner case in my mainnet wallet where I load a restore a wallet, call rescanblockchain from RPC, and it's "double counting" an output I've sent to myself since currently it never marks input transactions as dirty. This is fixed by a restart of the wallet.

    Note that this only happens with keys with birthdate after the blocks containing the spent funds which gets scanned on startup, so it's hard to test without a set seed function.

  2. fanquake added the label Wallet on Apr 11, 2018
  3. instagibbs force-pushed on Apr 11, 2018
  4. instagibbs referenced this in commit 8988b31ec2 on Apr 16, 2018
  5. instagibbs referenced this in commit 7c47412c93 on Apr 16, 2018
  6. jonasschnelli commented at 3:25 PM on April 17, 2018: contributor

    Makes sense. Thanks for the fix. utACK afd4c643c5813fe37051ab0ec55591be962e0d98

  7. instagibbs referenced this in commit 6d2dfd36bf on Apr 18, 2018
  8. instagibbs referenced this in commit 60ce1a1b30 on Apr 18, 2018
  9. instagibbs referenced this in commit c8b26290ed on Apr 18, 2018
  10. instagibbs referenced this in commit 18187ec8bf on May 15, 2018
  11. MarcoFalke added the label Needs rebase on Jun 6, 2018
  12. ScanforWalletTransactions should mark input txns as dirty 3c292cc190
  13. instagibbs force-pushed on Jun 14, 2018
  14. instagibbs commented at 1:58 PM on June 14, 2018: member

    rebased

  15. DrahtBot removed the label Needs rebase on Jun 14, 2018
  16. achow101 commented at 6:29 PM on July 13, 2018: member

    utACK 3c292cc190b1739ffcbec79b264aaded00c08e2c

  17. DrahtBot cross-referenced this on Jul 13, 2018 from issue [moveonly] Extract CWallet::MarkInputsDirty, and privatize AddToWalletIfInvolvingMe by Empact
  18. jonasschnelli commented at 7:33 PM on July 13, 2018: contributor

    utACK 3c292cc190b1739ffcbec79b264aaded00c08e2c

  19. jonasschnelli merged this on Jul 13, 2018
  20. jonasschnelli closed this on Jul 13, 2018
  21. jonasschnelli referenced this in commit 619cd29393 on Jul 13, 2018
  22. Bushstar cross-referenced this on Jul 16, 2018 from issue commits from bitcoin/master by Bushstar
  23. instagibbs referenced this in commit 2fc893d0bc on Jul 29, 2018
  24. ryanofsky cross-referenced this on Aug 3, 2018 from issue Refactor: separate wallet from node by ryanofsky
  25. jasonbcox referenced this in commit 16ceb135d7 on Dec 20, 2019
  26. jonspock referenced this in commit 6af78f4b69 on Oct 2, 2020
  27. jonspock referenced this in commit 84533e1f1b on Oct 5, 2020
  28. jonspock referenced this in commit 7e8aed9188 on Oct 10, 2020
  29. PastaPastaPasta referenced this in commit 3239c7b4fb on Jun 27, 2021
  30. PastaPastaPasta referenced this in commit 31196a52ca on Jun 28, 2021
  31. PastaPastaPasta referenced this in commit fd2fde79ef on Jun 28, 2021
  32. PastaPastaPasta referenced this in commit c3ee2cf8e3 on Jun 28, 2021
  33. PastaPastaPasta referenced this in commit 1674f523fe on Jun 28, 2021
  34. PastaPastaPasta referenced this in commit 80e9ba46a9 on Jun 29, 2021
  35. UdjinM6 referenced this in commit 5c0a5e7b3f on Jun 29, 2021
  36. bitcoin locked this on Sep 8, 2021
Contributors
instagibbsjonasschnelliachow101
Labels
Wallet
Linked (view graph)
#10973 Refactor: separate wallet from node
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:54 UTC