Make Deploy for Cross Compile Windows Fails #12876

issue 2a5A1Ghu1 opened this issue on April 4, 2018
  1. 2a5A1Ghu1 commented at 4:24 AM on April 4, 2018: none

    <!-- This issue tracker is only for technical issues related to Bitcoin Core. General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com. For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/. If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->

    <!-- Describe the issue -->

    When running make deploy during cross compile setup.exe fails to build

    <!--- What behavior did you expect? -->

    setup.exe is built

    <!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->

    fails to be built

    <!--- How reliably can you reproduce the issue, what are the steps to do so? -->

    Follow ubuntu cross compile instructions for windows and run make deploy after make

    <!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->

    bitcoin-core 0.16

    <!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->

    ubuntu 14.04 VM (2 core 2G Ram Allocated) on Macbook Pro (15-inch, mid 2012) macOS 10.13.3 2.6 GHz Intel Core i7 16 GB 1600 MHz DDR3 NVIDIA GeForce GT 650M 1 GB Intel HD Graphics 4000 1536 MB

    <!-- Any extra information that might be useful in the debugging process. -->

    ubuntu:~/Desktop/bitcoin-0.16$ make deploy Making all in src make[1]: Entering directory /home/bitcoin/Desktop/bitcoin-0.16/src' make[2]: Entering directory /home/bitcoin/Desktop/bitcoin-0.16/src' make[3]: Entering directory /home/bitcoin/Desktop/bitcoin-0.16' make[3]: Leaving directory /home/bitcoin/Desktop/bitcoin-0.16' make[2]: Leaving directory /home/bitcoin/Desktop/bitcoin-0.16/src' make[1]: Leaving directory /home/bitcoin/Desktop/bitcoin-0.16/src' Making all in doc/man make[1]: Entering directory /home/bitcoin/Desktop/bitcoin-0.16/doc/man' make[1]: Nothing to be done for all'. make[1]: Leaving directory /home/bitcoin/Desktop/bitcoin-0.16/doc/man' make[1]: Entering directory /home/bitcoin/Desktop/bitcoin-0.16' make[1]: Nothing to be done for all-am'. make[1]: Leaving directory /home/bitcoin/Desktop/bitcoin-0.16' /bin/mkdir -p ./release STRIPPROG="/usr/bin/x86_64-w64-mingw32-strip" /bin/bash /home/bitcoin/Desktop/bitcoin-0.16/build-aux/install-sh -c -s ./src/bitcoind.exe ./release STRIPPROG="/usr/bin/x86_64-w64-mingw32-strip" /bin/bash /home/bitcoin/Desktop/bitcoin-0.16/build-aux/install-sh -c -s ./src/qt/bitcoin-qt.exe ./release STRIPPROG="/usr/bin/x86_64-w64-mingw32-strip" /bin/bash /home/bitcoin/Desktop/bitcoin-0.16/build-aux/install-sh -c -s ./src/bitcoin-cli.exe ./release error: could not build bitcoin-0.16.0-win64-setup.exe built bitcoin-0.16.0-win64-setup.exe

    <!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->

    config.log

  2. fanquake added the label Build system on Apr 4, 2018
  3. globaltoken commented at 6:04 AM on April 9, 2018: none

    Did you installed all dependencies?

  4. hanzou-x commented at 8:08 PM on April 16, 2018: none

    Pretty sure @buddilla must have installed/built everything in the depends/ subfolder , as that's required in order to build bitcoin-qt.exe.

    Some days ago I hit the same error on a Litecoin forked altcoin, so I went back to bitcoin master and the error is the same for me:

    STRIPPROG="/usr/bin/x86_64-w64-mingw32-strip" /bin/bash /home/hanzou/bitcoin/build-aux/install-sh -c -s ./src/qt/bitcoin-qt.exe ./release
    STRIPPROG="/usr/bin/x86_64-w64-mingw32-strip" /bin/bash /home/hanzou/bitcoin/build-aux/install-sh -c -s ./src/bitcoin-cli.exe ./release
    error: could not build bitcoin-0.16.99-win64-setup.exe
    built bitcoin-0.16.99-win64-setup.exe
    

    (also evidently it doesn't propagate errors well, the last line thinking it was built successfully.)

    There is zero mention of NSIS in https://github.com/bitcoin/bitcoin/blob/master/doc/build-windows.md but this worked for me:

    sudo apt install nsis
    makensis share/setup.nsi
    

    That successfully built a working bitcoin-0.1.16.99-win64-setup.exe

  5. 2a5A1Ghu1 commented at 9:36 PM on April 16, 2018: none

    Yep that was it. thank you

  6. 2a5A1Ghu1 closed this on Apr 16, 2018

  7. hanzou-x commented at 2:38 PM on April 17, 2018: none

    Ok, make deploy works for me if I install NSIS first. Still:

    • Someone should update the docs to include the makensis dependency
    • It should output something while running makensis, rather than having the silent step after stripping binaries
    • When it fails, shouldn't say "built bitcoin-0.16.99-win64-setup.exe"
  8. shohu cross-referenced this on Sep 7, 2018 from issue Create windows binary by shohu
  9. shohu referenced this in commit 216504dae3 on Sep 21, 2018
  10. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:54 UTC