[build] Tune wildcards for LIBSECP256K1 target #12788

pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:build-tune-libsecp256k1-wildcards changing 1 files +1 −1
  1. kallewoof commented at 9:40 AM on March 26, 2018: member

    Automake would think the target was out of date every time because e.g. '.deps' was updated.

    Note: I am assuming that secp256k1 depends on *.h, *.c, and libsecp256k1-config.h (it's .h so already included), aside from pre-existing include/*. If there are other files that would require a rebuild of the LIBSECP256K1 target, they should probably be added.

    It would be neat if you could exclude specific files, rather than split it up like this, but it doesn't seem possible (https://www.gnu.org/software/make/manual/html_node/Wildcard-Function.html#Wildcard-Function)

    Should probably note this:

    $ V=1 make check VERBOSE=1
    Making check in src
    make[1]: Entering directory '/home/user/workspace/bitcoin/src'
    make[2]: Entering directory '/home/user/workspace/bitcoin/src'
    make  -C secp256k1 libsecp256k1.la
    make[3]: Entering directory '/home/user/workspace/bitcoin/src/secp256k1'
    make[3]: 'libsecp256k1.la' is up to date.
    make[3]: Leaving directory '/home/user/workspace/bitcoin/src/secp256k1'
    make  check-TESTS check-local
    make[3]: Entering directory '/home/user/workspace/bitcoin/src'
    make[4]: Entering directory '/home/user/workspace/bitcoin/src'
    make  -C secp256k1 libsecp256k1.la
    make[5]: Entering directory '/home/user/workspace/bitcoin/src/secp256k1'
    make[5]: 'libsecp256k1.la' is up to date.
    make[5]: Leaving directory '/home/user/workspace/bitcoin/src/secp256k1'
    PASS: test/test_bitcoin.exe
    
  2. fanquake added the label Build system on Mar 26, 2018
  3. fanquake requested review from theuni on Mar 26, 2018
  4. kallewoof force-pushed on Mar 27, 2018
  5. laanwj commented at 2:25 PM on March 27, 2018: member

    Concept ACK, but deferring to @theuni.

    FWIW univalue has the opposite problem. It's possible to change some files without it being detected by the build system.

  6. laanwj assigned theuni on Apr 10, 2018
  7. DrahtBot cross-referenced this on Jun 7, 2018 from issue crypto: cleanup sha256 build by theuni
  8. DrahtBot added the label Needs rebase on Jun 11, 2018
  9. [build] Tune wildcards for LIBSECP256K1 target
    Automake would think the target was out of date every time because e.g. '.deps' was updated.
    98b1813230
  10. kallewoof force-pushed on Jun 12, 2018
  11. kallewoof commented at 7:25 AM on June 12, 2018: member

    Rebased.

  12. DrahtBot removed the label Needs rebase on Jun 12, 2018
  13. theuni approved
  14. theuni commented at 7:36 PM on June 12, 2018: member

    utACK 98b18132308e9524efc3364500770341c666ac90.

  15. laanwj merged this on Jul 5, 2018
  16. laanwj closed this on Jul 5, 2018

  17. laanwj referenced this in commit 287e4edc2f on Jul 5, 2018
  18. kallewoof deleted the branch on Jul 6, 2018
  19. Bushstar cross-referenced this on Jul 9, 2018 from issue commits from bitcoin/master by Bushstar
  20. PastaPastaPasta referenced this in commit 2d9bd1945c on Jul 9, 2020
  21. PastaPastaPasta referenced this in commit 4f75487a81 on Jul 9, 2020
  22. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC