configure: UniValue 1.0.4 is required for pushKV(, bool) #12666

1. 
   luke-jr commented at 10:16 PM on March 10, 2018: member

   The breaking changes (#12193) are already merged, so this blocks 0.17.0.

   It depends on jgarzik/univalue#42 or jgarzik/univalue#50 being merged and released in UniValue 1.0.4.

2. configure: UniValue 1.0.4 is required for pushKV(, bool) 8172d3aadb
3. fanquake added the label Build system on Mar 10, 2018
4. 
   promag commented at 7:07 PM on March 11, 2018: member

   Ah so this is what you meant the other day.

5. luke-jr cross-referenced this on Mar 11, 2018 from issue rpc: Add testmempoolaccept by MarcoFalke
6. MarcoFalke added this to the milestone 0.17.0 on Mar 11, 2018
7. 
   laanwj commented at 4:55 PM on March 12, 2018: member

   Makes sense, utACK https://github.com/bitcoin/bitcoin/pull/12666/commits/8172d3aadb125340d4008b9aa81a3800f0370d1f

8. laanwj assigned theuni on Mar 12, 2018
9. 
   meshcollider commented at 9:11 PM on March 13, 2018: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/12666/commits/8172d3aadb125340d4008b9aa81a3800f0370d1f

10. laanwj merged this on Mar 14, 2018
11. laanwj closed this on Mar 14, 2018

    ---

12. laanwj referenced this in commit 05042d38ba on Mar 14, 2018
13. 
    Sjors commented at 3:31 PM on March 14, 2018: member

    Isn't this merge premature given that 1.0.4. isn't released yet? Or should there be a ticket in the 0.17 milestone to make sure 1.0.4 is released and compatible?

14. jonassmedegaard cross-referenced this on Aug 21, 2018 from issue Please issue new release 1.0.4 by jonassmedegaard
15. jnewbery cross-referenced this on Dec 20, 2018 from issue Bitcoin Core should not have a fork of univalue by luke-jr
16. PastaPastaPasta referenced this in commit 6fbecce2ce on Jun 10, 2020
17. PastaPastaPasta referenced this in commit e8e865e62b on Jun 13, 2020
18. PastaPastaPasta referenced this in commit ae80b66a3c on Jun 13, 2020
19. PastaPastaPasta referenced this in commit 2e9bccee4f on Jun 13, 2020
20. PastaPastaPasta referenced this in commit ede8859492 on Jun 14, 2020
21. PastaPastaPasta referenced this in commit a4dd30d20a on Jun 17, 2020
22. gades referenced this in commit e9082e6d0b on Jun 26, 2021
23. MarcoFalke cross-referenced this on Jul 7, 2021 from issue Bugfix: Workaround UniValue push_back(bool) limitation with push_back(UniValue(bool)) by luke-jr
24. bitcoin locked this on Sep 8, 2021

Contributors

luke-jrpromaglaanwjmeshcolliderSjors

Milestone
0.17.0