gitian-build.sh: fix signProg being recognized as two parameters #12527

pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:master changing 1 files +13 −13

ken2812221 commented at 2:24 PM on February 24, 2018: contributor

On current build script, gpg --detach-sign will be recognized as two parameters of gsign This PR fix it and can build successfully
fanquake added the label Scripts and tools on Feb 24, 2018
practicalswift commented at 4:29 PM on February 24, 2018: contributor

Concept ACK
MarcoFalke commented at 5:01 PM on February 25, 2018: member

utACK c3f32534985331d6e60be568da0af212bb9ec0f4
gitian-build.sh: fix signProg being recognized as two parameters 87c4320dfc

in contrib/gitian-build.sh:275 in c3f3253498 outdated

 271 | @@ -272,7 +272,7 @@ then
 272 |  	    echo "Compiling ${VERSION} Linux"
 273 |  	    echo ""
 274 |  	    ./bin/gbuild -j ${proc} -m ${mem} --commit bitcoin=${COMMIT} --url bitcoin=${url} ../bitcoin/contrib/gitian-descriptors/gitian-linux.yml
 275 | -	    ./bin/gsign -p $signProg --signer $SIGNER --release ${VERSION}-linux --destination ../gitian.sigs/ ../bitcoin/contrib/gitian-descriptors/gitian-linux.yml
 276 | +	    ./bin/gsign -p "$signProg" --signer $SIGNER --release ${VERSION}-linux --destination ../gitian.sigs/ ../bitcoin/contrib/gitian-descriptors/gitian-linux.yml

laanwj commented at 6:54 PM on March 1, 2018:

Would it make sense to do the same for all the other arguments? E.g. "$SIGNER" would make it possible to have signer names with spaces in them.

ken2812221 commented at 7:52 PM on March 1, 2018:

done

laanwj commented at 5:49 PM on March 5, 2018: member

utACK 87c4320dfc8eff46f13851ab8a1651a84d2301da
laanwj merged this on Mar 5, 2018
laanwj closed this on Mar 5, 2018
laanwj referenced this in commit d77b4a7bcf on Mar 5, 2018
MarcoFalke commented at 5:58 PM on March 5, 2018: member

Could you please do the same to doc/release-process.md?
ken2812221 cross-referenced this on Mar 6, 2018 from issue doc: allow for SIGNER containing spaces by ken2812221
laanwj referenced this in commit 1f9349129d on Mar 6, 2018
dagurval cross-referenced this on Jun 12, 2018 from issue Easy to use gitian building script by dagurval
HashUnlimited referenced this in commit a85c98f995 on Jul 31, 2018
lionello referenced this in commit 014bdaf819 on Nov 7, 2018
PastaPastaPasta referenced this in commit e07348d5bd on Jun 13, 2020
PastaPastaPasta referenced this in commit 7537d27de2 on Jun 13, 2020
PastaPastaPasta referenced this in commit 5d88333da6 on Jun 14, 2020
PastaPastaPasta referenced this in commit ba9255ea67 on Jun 17, 2020
PastaPastaPasta referenced this in commit 6c1f9d03c2 on Jun 17, 2020
PastaPastaPasta referenced this in commit 66f9a387e7 on Jun 17, 2020
PastaPastaPasta referenced this in commit 95edea4e3e on Jun 17, 2020
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#12615 doc: allow for SIGNER containing spaces