[Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server #12490

pull jnewbery wants to merge 3 commits into bitcoin:master from jnewbery:remove_deprecated_rpcs changing 5 files +18 −150

jnewbery commented at 2:21 PM on February 20, 2018: member
The following rpc features were deprecated in V0.17:
- validateaddress returning wallet information about an address
- signrawtransaction
This PR fully removes those features. It can be merged once V0.17 has been branched from master.
jnewbery commented at 2:22 PM on February 20, 2018: member

open-closing this PR so the branch is available to everyone. This ~+ #10762~ should allow server to be built without any dependencies on wallet.

Will re-open once V0.17 has been branched.

Edit: #10762 has been merged. I've now rebased this on master.
jnewbery closed this on Feb 20, 2018
jnewbery renamed this:
~~Remove deprecated wallet rpc methods from server~~
Remove deprecated wallet rpc features from bitcoin_server
on Feb 20, 2018
jnewbery cross-referenced this on Feb 20, 2018 from issue Remaining instances of ENABLE_WALLET in `libbitcoin_server.a` by laanwj
bitcoin deleted a comment on Feb 20, 2018
jnewbery cross-referenced this on Feb 20, 2018 from issue [PoC] Add wallet inspection and modification tool "bitcoin-wallet-tool" by jonasschnelli
achow101 cross-referenced this on Mar 7, 2018 from issue [RPC] Split signrawtransaction into multiple distinct RPCs by achow101
jnewbery reopened this on Apr 3, 2018
jnewbery force-pushed on Apr 3, 2018
jnewbery closed this on Apr 3, 2018
jnewbery reopened this on Aug 6, 2018
jnewbery force-pushed on Aug 6, 2018
jnewbery renamed this:
~~Remove deprecated wallet rpc features from bitcoin_server~~
[DO NOT MERGE UNTI Lv0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server
on Aug 6, 2018
jnewbery renamed this:
~~[DO NOT MERGE UNTI Lv0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server~~
[DO NOT MERGE UNTIL v0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server
on Aug 6, 2018
jnewbery commented at 3:06 PM on August 6, 2018: member

rebased
jnewbery force-pushed on Aug 6, 2018
jnewbery force-pushed on Aug 6, 2018
MarcoFalke added the label Wallet on Aug 6, 2018
DrahtBot cross-referenced this on Aug 6, 2018 from issue [wallet] Kill accounts by jnewbery

in src/rpc/misc.cpp:69 in 1158febc93 outdated

  72 | -#endif
  73 | -        if (ret["address"].isNull()) {
  74 | -            std::string currentAddress = EncodeDestination(dest);
  75 | -            ret.pushKV("address", currentAddress);
  76 | +        CScript scriptPubKey = GetScriptForDestination(dest);
  77 | +        ret.pushKV("scriptPubKey", HexStr(scriptPubKey.begin(), scriptPubKey.end()));;

MarcoFalke commented at 5:33 PM on August 6, 2018:

nit: No need for double semicolon?

jnewbery commented at 9:06 PM on August 6, 2018:

thanks. Fixed

MarcoFalke commented at 5:34 PM on August 6, 2018: member

utACK 1158febc93707910d783be863aa05c8f6cfedb2f
jnewbery force-pushed on Aug 6, 2018
jnewbery cross-referenced this on Aug 9, 2018 from issue [Tools] bitcoin-wallet - a tool for creating and managing wallets offline by jnewbery
DrahtBot cross-referenced this on Aug 12, 2018 from issue Refactoring CRPCCommand with enum category by isghe
jnewbery renamed this:
~~[DO NOT MERGE UNTIL v0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server~~
[Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server
on Aug 14, 2018
jnewbery commented at 11:06 AM on August 14, 2018: member

V0.17 has been branched. This is ready for review/merge
DrahtBot cross-referenced this on Aug 22, 2018 from issue Remove accounts rpcs by jnewbery
DrahtBot added the label Needs rebase on Aug 27, 2018
[rpc] Remove deprecated validateaddress usage. df905e390e

[RPC] Remove warning about wallet addresses in createmultisig()

createmultisig() was updated in V0.16 to not use the wallet. Warning
text was included to warn the user. Remove that now.

90c834089a

[rpc] Remove deprecated sigrawtransaction rpc method. f7e9e70468
jnewbery force-pushed on Aug 27, 2018
jnewbery commented at 6:38 PM on August 27, 2018: member

rebased
DrahtBot removed the label Needs rebase on Aug 27, 2018
MarcoFalke commented at 7:08 PM on August 29, 2018: member

re-utACK f7e9e704683be4d6be4c9ea600a479bc02976313
promag commented at 12:42 AM on September 7, 2018: member

utACK f7e9e70.
MarcoFalke referenced this in commit 4799b0932a on Sep 7, 2018
MarcoFalke merged this on Sep 7, 2018
MarcoFalke closed this on Sep 7, 2018
ptyx11 commented at 2:08 PM on September 11, 2018: none

What was the reasoning behind this? It seems unnecessary.
achow101 commented at 2:18 PM on September 11, 2018: member

@ptyx11 This is part of the separation of the wallet from the node. Those RPCs were node RPCs which involved wallet things, so they needed to be removed. They have been deprecated for at least one major version with replacement RPCs already available.
lautarodragan cross-referenced this on Oct 10, 2018 from issue Deprecated signrawtransaction by lautarodragan
Bushstar cross-referenced this on Oct 11, 2018 from issue Updates from bitcoin/master by Bushstar
jnewbery cross-referenced this on Apr 10, 2019 from issue [rpc] Remove the addresses field from the getaddressinfo return object by jnewbery
deadalnix referenced this in commit 92eafd93e7 on Mar 20, 2020
ftrader referenced this in commit 6380b4c592 on May 19, 2020
dzutto referenced this in commit cff4d95913 on Aug 30, 2021
dzutto referenced this in commit 4ce386c1e9 on Aug 30, 2021
PastaPastaPasta referenced this in commit 6d90e71076 on Sep 1, 2021
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7965 Remaining instances of ENABLE_WALLET in `libbitcoin_server.a`#8745 [PoC] Add wallet inspection and modification tool "bitcoin-wallet-tool"#10570 [RPC] Split signrawtransaction into multiple distinct RPCs #10762 [wallet] Remove Wallet dependencies from init.cpp #13926 [Tools] bitcoin-wallet - a tool for creating and managing wallets offline #15750 [rpc] Remove the addresses field from the getaddressinfo return object