Assert CPubKey::ValidLength to the pubkey's header-relevant size #12460

1. 
   Empact commented at 8:37 PM on February 16, 2018: member

   A pubkey's length is specific to its type which is indicated by its header value. GetLen returns the header-indicated length, so this change ensures that a key matches its header-indicated length.

   And replace some magic values with their constant equivalents.

2. Assert CPubKey::ValidLength to the pubkey's header-relevent size

   Previously this was an inline test where the specificity was probably judged
   overly specific. As a class method it makes sense to maintain consistency.
   
   And replace some magic values with their constant equivalents.

   f8c249ab91
3. Empact cross-referenced this on Feb 16, 2018 from issue Add header-sensitive size checking via CPubKey::ValidSize, and prefer key/sig size const references by Empact
4. 
   devrandom commented at 9:22 PM on February 16, 2018: none

   utACK https://github.com/bitcoin/bitcoin/pull/12460/commits/f8c249ab918b0b4d326b8c441816c64d046455bf

5. Empact renamed this:
   Assert CPubKey::ValidLength to the pubkey's header-relevent size
   Assert CPubKey::ValidLength to the pubkey's header-relevant size
   on Feb 16, 2018
6. fanquake added the label Refactoring on Feb 17, 2018
7. 
   jonasschnelli commented at 11:15 AM on February 17, 2018: contributor

   utACK f8c249ab918b0b4d326b8c441816c64d046455bf

8. dcousens approved
9. 
   dcousens commented at 11:37 PM on February 18, 2018: contributor

   utACK

10. 
    MarcoFalke commented at 11:45 PM on February 18, 2018: member

    utACK f8c249a

11. 
    practicalswift commented at 4:34 PM on February 24, 2018: contributor

    utACK f8c249ab918b0b4d326b8c441816c64d046455bf

12. fanquake requested review from sipa on Mar 14, 2018
13. 
    jnewbery commented at 6:32 PM on April 4, 2018: member

    5 utACKs. Ready for merge?

14. 
    promag commented at 6:39 PM on April 4, 2018: member

    utACK f8c249a.

15. MarcoFalke merged this on Apr 4, 2018
16. MarcoFalke closed this on Apr 4, 2018

    ---

17. MarcoFalke referenced this in commit bfaed1ab2e on Apr 4, 2018
18. Empact deleted the branch on Apr 4, 2018
19. Empact referenced this in commit c682e70a8e on Apr 12, 2018
20. Empact referenced this in commit ef298ef86e on Apr 12, 2018
21. Empact referenced this in commit 078697b066 on Apr 12, 2018
22. Empact cross-referenced this on Apr 12, 2018 from issue Drop IsCompressedOrUncompressedPubKey and IsCompressedPubKey by Empact
23. Empact referenced this in commit e365c28259 on Oct 9, 2018
24. sickpig cross-referenced this on Sep 24, 2019 from issue [port] Improvements to ECDSA key-handling code by sickpig
25. str4d cross-referenced this on Nov 14, 2019 from issue Bitcoin script PRs 1 by str4d
26. zkbot referenced this in commit 63c3d1ec94 on Dec 17, 2019
27. furszy cross-referenced this on Jun 18, 2020 from issue Upstream scripts back ports [Step 1] by furszy
28. furszy referenced this in commit a5265a4db4 on Jun 27, 2020
29. PastaPastaPasta referenced this in commit 0bc059b369 on Jul 19, 2020
30. PastaPastaPasta referenced this in commit ee6f3d0baa on Jul 24, 2020
31. PastaPastaPasta referenced this in commit 6419bceeb7 on Jul 27, 2020
32. UdjinM6 referenced this in commit 93e63d6726 on Jul 27, 2020
33. UdjinM6 referenced this in commit 28a6901fca on Jul 27, 2020
34. PastaPastaPasta referenced this in commit a57abd75d1 on Jun 27, 2021
35. PastaPastaPasta referenced this in commit 43b487f2fa on Jun 28, 2021
36. PastaPastaPasta referenced this in commit 8058b70f99 on Jun 28, 2021
37. PastaPastaPasta referenced this in commit b995a71feb on Jun 28, 2021
38. PastaPastaPasta referenced this in commit a15668be15 on Jun 28, 2021
39. PastaPastaPasta referenced this in commit d8fc1c0fe8 on Jun 29, 2021
40. bitcoin locked this on Sep 8, 2021

Contributors

EmpactdevrandomjonasschnellidcousensMarcoFalkepracticalswiftjnewberypromag

Review Requested
sipa