[Docs] Updated examples in CONTRIBUTING.md #12410

pull Willtech wants to merge 1 commits into bitcoin:master from Willtech:CONTRIBUTING.md changing 1 files +4 −4

Willtech commented at 3:28 AM on February 11, 2018: contributor

Updated examples in CONTRIBUTING.md to match currenty accepted convention e.g. [DOCS] {Verbose (50 char max) subject line}

Signed-off-by: Damian Williamson willtech@live.com.au

[Docs] Updated examples in CONTRIBUTING.md

Updated examples in `CONTRIBUTING.md` to match currenty accepted convention e.g. [DOCS] {Verbose (50 char max) subject line}

Signed-off-by: Damian Williamson <willtech@live.com.au>

c5a887b5fb

fanquake added the label Docs on Feb 11, 2018
randolf approved
Willtech commented at 6:41 AM on February 11, 2018: contributor

Per this event.
promag commented at 10:57 AM on February 11, 2018: member

Actually on PR titles I prefer github labels instead of prefixes, because a PR can affect multitple areas.
Willtech cross-referenced this on Feb 11, 2018 from issue TODO for release notes 0.17.0 by laanwj
laanwj commented at 9:22 AM on February 12, 2018: member

I still prefer prefix: to [prefix]. This is what linux, SDL, and many other projects use, I haven't ever seen the [xxx] convention for commits and I'm not sure why we need our own unique one. So NACK on changing this.

Actually on PR titles I prefer github labels instead of prefixes, because a PR can affect multitple areas.

Contributors can't set these themselves. Labeling is up to the repo owners (possibly based on those hints). Also labels are per-PR and not per-commit.
laanwj commented at 9:24 AM on February 12, 2018: member

Per this event.

Not sure why @fanquake was changing that, but I disagree obviously :)
promag commented at 9:52 AM on February 12, 2018: member

I think prefixes are enough in commits (not against at all) and then someone with permissions (@fanquake for instance) set the correct labels on PR.

As for the prefix format, we should just use one.
randolf commented at 7:52 PM on February 13, 2018: contributor

@promag As long as it's easy to use and communicates clearly, I think it's better to have only one convention for this (whatever the consensus turns out to be).
laanwj closed this on Mar 5, 2018
Willtech deleted the branch on Mar 6, 2018
Willtech restored the branch on Apr 12, 2018
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#12384 [Docs] Add version footnote to tor.md #12391 TODO for release notes 0.17.0