after some trial an error i finally fixed the issues i had with git. see #11843
Moving to python3 #11895
pull cjavad wants to merge 0 commits into bitcoin:master from cjavad:master changing 0 files +0 −0-
cjavad commented at 10:06 AM on December 14, 2017: none
- cjavad cross-referenced this on Dec 14, 2017 from issue Use python not 'python2' by cjavad
-
jnewbery commented at 12:43 PM on December 14, 2017: member
Opening a new PR for this wasn't necessary. It loses the entire review thread and spams contributors with additional notifications.
Can you close this and re-open the original PR? I think you may need to do the following:
git reset --hard HEAD~(git won't let you re-open a PR if the branch has changed since it closed)git push -f- reopen #11843 and close this
git reset --hard 95108d7f1a82d9807abdbbf65959e4453d3a623c(to get back to this commit)git push -f
Then address the feedback from Marco in that PR (change security-check.py to use python3 as well)
- fanquake added the label Scripts and tools on Dec 15, 2017
- cjavad closed this on Dec 17, 2017
-
-
jnewbery commented at 1:10 AM on December 18, 2017: member
ok, since the the JavadSM:master branch no longer has any commits, you won't be able to re-open the original PR:
<img width="739" alt="screen shot 2017-12-17 at 8 08 00 pm" src="https://user-images.githubusercontent.com/1063656/34086011-2ada53d8-e366-11e7-8800-e48f17c0cded.png">
so reset your master branch onto commit 95108d7f1a82d9807abdbbf65959e4453d3a623c, then force push it, and then you should be able to re-open to original PR. I've tested this myself with a PR and it should work.
- bitcoin locked this on Sep 8, 2021
Labels