dumpwallet command is not clear and can damage the wallet file #11798

issue bsod85 opened this issue on November 30, 2017
  1. bsod85 commented at 11:34 AM on November 30, 2017: none

    It seems to me that it's not clear that dumpwallet command parameter is the destination file. At first glance I thought it was the source wallet.dat file and the content would be dumped into the console. This caused the loss of the wallet file (it truncated the file to zero length). I had a backup but I think a check that the specified file is not the current wallet (to avoid accidental data and coins loss), and a clearer explanation in the console command help text should be added.

  2. promag commented at 1:18 PM on November 30, 2017: member

    IIRC the dump should not work if the destination file exists.

  3. promag commented at 1:19 PM on November 30, 2017: member

    What version are you using?

  4. bsod85 commented at 3:10 PM on November 30, 2017: none

    v0.14.1.0-g964a185 (64-bit)

  5. promag commented at 3:15 PM on November 30, 2017: member

    This was fixed in #9937. Mind closing?

  6. bsod85 commented at 3:18 PM on November 30, 2017: none

    Yes, sorry

  7. bsod85 closed this on Nov 30, 2017

  8. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC