qa: Remove unused NodeConn members #11677

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1711-qaMininodeUnused changing 4 files +10 −13

MarcoFalke commented at 10:47 PM on November 13, 2017: member
- ver_send and ver_recv were completely unused
- rpc was only used once, in p2p-segwit. Imo better only pass it to the constructor in that single test
qa: Remove unused NodeConn members fafdad0d46
MarcoFalke added the label Tests on Nov 13, 2017
promag commented at 2:18 PM on November 14, 2017: member

Tested ACK fafdad0 (extended tests pass).
jnewbery commented at 10:09 PM on November 14, 2017: member

Tested ACK fafdad0d461330aee7a17db57a9d8f25906203cc.

Thanks! This is part of #11518
jnewbery cross-referenced this on Nov 14, 2017 from issue [tests] [demonstration] Simplify/clarify the NodeConn/NodeConnCB mininode classes by jnewbery
MarcoFalke commented at 10:45 PM on November 14, 2017: member

Sorry, haven't looked at #11518 in detail. Though, good to see we agree on this diff and did the same thing.
MarcoFalke merged this on Nov 14, 2017
MarcoFalke closed this on Nov 14, 2017
MarcoFalke referenced this in commit 3bdf242fc6 on Nov 14, 2017
MarcoFalke deleted the branch on Nov 14, 2017
PastaPastaPasta referenced this in commit 57c65f42d6 on Feb 13, 2020
PastaPastaPasta referenced this in commit 783b6831bd on Feb 13, 2020
PastaPastaPasta referenced this in commit 4ec4e349d2 on Feb 29, 2020
ckti referenced this in commit 4c5de2e01a on Mar 28, 2021
gades referenced this in commit 1f65e4f634 on Jun 30, 2021
bitcoin locked this on Sep 8, 2021

Contributors

Labels