p2p: Remove dead service bits code #11637

1. 
   MarcoFalke commented at 6:41 PM on November 8, 2017: member

   Seems fine to remove for the upcoming 0.17 release

   Fixes #10993

2. MarcoFalke added the label P2P on Nov 8, 2017
3. 
   theuni commented at 7:05 PM on November 8, 2017: member

   I think this is premature. Since it was shipped in 15.0, we need to consider this behavior locked-in until August. We can't practically re-use the bits until then anyway, and we still don't want to remain connected to any peer with them enabled for whatever reason.

   Also, I assume the 1 << 5 is still relevant.

4. MarcoFalke added this to the milestone Future on Nov 8, 2017
5. MarcoFalke renamed this:
   Remove dead service bits code
   WIP: Remove dead service bits code
   on Nov 8, 2017
6. 
   MarcoFalke commented at 7:17 PM on November 8, 2017: member

   Good point about keeping it in the code for now to make clear that they are taken. Guess there is no rush in merging this.

7. 
   Sjors commented at 7:18 PM on November 8, 2017: member

   Isn't one needed for Bitcoin Cash nodes?

   If it can be done without side-effects, it would be a nice gesture to at least deprecate it (earlier).

8. meshcollider cross-referenced this on Nov 8, 2017 from issue Return service bits 6 and 8 on Aug 1, 2018 by TheBlueMatt
9. 
   MarcoFalke commented at 1:56 AM on December 6, 2017: member

   Needs rebase. No need to keep open; Closing for now.

10. MarcoFalke closed this on Dec 6, 2017

    ---

11. MarcoFalke deleted the branch on Dec 6, 2017
12. MarcoFalke restored the branch on Jul 11, 2018
13. MarcoFalke removed this from the milestone Future on Jul 11, 2018
14. MarcoFalke added this to the milestone 0.17.0 on Jul 11, 2018
15. MarcoFalke renamed this:
    WIP: Remove dead service bits code
    Remove dead service bits code
    on Jul 11, 2018
16. MarcoFalke renamed this:
    Remove dead service bits code
    p2p: Remove dead service bits code
    on Jul 11, 2018
17. Remove dead service bits code fa4bf92be9
18. MarcoFalke reopened this on Jul 11, 2018

    ---

19. MarcoFalke force-pushed on Jul 11, 2018
20. 
    laanwj commented at 12:11 PM on July 17, 2018: member

    utACK fa4bf92be9420919c74cdde9a973f7327d01ac88

21. 
    Sjors commented at 12:27 PM on July 17, 2018: member

    Concept ACK @theuni wrote:

    consider this behavior locked-in until August

    That should work with the expect v0.17 release, right?

    I wrote:

    Isn't one needed for Bitcoin Cash nodes?

    One year seems long enough for me, especially since they've rolled out multiple hard forks that could have dealt with any potential node confusion (I haven't checked if they did).

22. 
    achow101 commented at 9:27 PM on July 18, 2018: member

    utACK fa4bf92be9420919c74cdde9a973f7327d01ac88

23. 
    sipa commented at 9:52 PM on July 19, 2018: member

    utACK fa4bf92be9420919c74cdde9a973f7327d01ac88

24. 
    laanwj commented at 1:13 PM on July 20, 2018: member

    utACK fa4bf92be9420919c74cdde9a973f7327d01ac88

25. laanwj merged this on Jul 20, 2018
26. laanwj closed this on Jul 20, 2018

    ---

27. laanwj referenced this in commit c575260f80 on Jul 20, 2018
28. MarcoFalke deleted the branch on Jul 20, 2018
29. Bushstar cross-referenced this on Jul 24, 2018 from issue commits from bitcoin/master by Bushstar
30. PastaPastaPasta referenced this in commit 29ffc70771 on Dec 21, 2020
31. PastaPastaPasta referenced this in commit b4c35cac0f on Jan 11, 2021
32. PastaPastaPasta referenced this in commit 72e13944fd on Jan 11, 2021
33. PastaPastaPasta referenced this in commit 49a9d02c46 on Feb 2, 2021
34. bitcoin locked this on Sep 8, 2021

Contributors

MarcoFalketheuniSjorslaanwjachow101sipa

Milestone
0.17.0