[Wallet] always show help-line of wallet encryption calls #11590

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2017/10/enc_wallet_help changing 1 files +4 −4

jonasschnelli commented at 6:34 AM on November 1, 2017: contributor

We do currently show/hide the wallet encryption RPC calls from the help if the current wallet. In case of an encrypted wallet, encryptwallet is hidden and walletpassphrasechange, walletpassphrasechange and walletlock do appear in the help.

This is no longer ideal in case of multiwallet due to the fact that one may want help infos in order to target a specific wallet.

IMO its preferable to have a static help screen (show everything always). The currently show/hidden calls do handle the possible invalid encryption-state fine.

Fixes #11588
[Wallet] always show help-line of wallet encryption calls 720d9e8fa1
jonasschnelli added the label Docs and Output on Nov 1, 2017
jonasschnelli added the label Wallet on Nov 1, 2017
jonasschnelli cross-referenced this on Nov 1, 2017 from issue "bitcoin-cli help" does not show how to encrypt additional multi wallets by juestr
MarcoFalke added this to the milestone 0.15.1 on Nov 1, 2017
MarcoFalke added the label Needs backport on Nov 1, 2017
MarcoFalke commented at 3:50 PM on November 1, 2017: member

Tested ACK 720d9e8fa1d1c7516e8278eaaf60789d2f2c8a53
promag commented at 12:22 AM on November 2, 2017: member

IMO its preferable to have a static help screen (show everything always).

With the exception of -disablewallet.

ACK 720d9e8.
MarcoFalke merged this on Nov 2, 2017
MarcoFalke closed this on Nov 2, 2017
MarcoFalke referenced this in commit bfb270acfa on Nov 2, 2017
juestr commented at 5:19 PM on November 2, 2017: none

@promag I am not too sure about -disablewallet even. IMHO at least a help line commenting that -disablewallet is in effect would still be useful from the user perspective.
MarcoFalke referenced this in commit 308e636712 on Nov 2, 2017
MarcoFalke referenced this in commit 6372a75581 on Nov 8, 2017
MarcoFalke removed the label Needs backport on Nov 9, 2017
MarcoFalke removed this from the milestone 0.15.2 on Nov 9, 2017
MarcoFalke commented at 7:40 PM on November 9, 2017: member

Removing backport tag: #11647
bambache cross-referenced this on Jan 31, 2019 from issue Merge #11590: [Wallet] always show help-line of wallet encryption calls by bambache
codablock referenced this in commit 6efad6f46d on Sep 26, 2019
codablock referenced this in commit 18f104b97e on Sep 30, 2019
barrystyle referenced this in commit c3b6f87941 on Jan 22, 2020
deadalnix referenced this in commit 4cd70a954d on Jun 15, 2020
random-zebra cross-referenced this on Apr 28, 2021 from issue [Wallet] Laggard wallet-related backports from btc 0.15 by random-zebra
random-zebra referenced this in commit 2d50b6e3b9 on Jun 9, 2021
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#11588 "bitcoin-cli help" does not show how to encrypt additional multi wallets #11647 0.15: Backports