Codeai fixes: remove dead code, prevent possible division by zero. #11488

pull C0deAi wants to merge 5 commits into bitcoin:master from QbitLogic:codeai-fixes changing 3 files +2 −4

C0deAi commented at 11:57 PM on October 11, 2017: none

CodeAi suggests the removal of 4 lines of dead code in log_reader.cc and pubkey.cpp.

CodeAi suggests inserting a check for scale to prevent possible division by zero in fees.cpp.
Remove dead code, CWE 561 81d478c384
Remove dead code, CWE 561 62913d3d41
Remove dead code, CWE 561 5fb487f46b
Remove dead code, CWE 561 e54876a514
Prevent possible divide by zero, CWE 369 db470ddd61
fanquake commented at 12:03 AM on October 12, 2017: member

The leveldb changes need to be directed upstream. The fees assert change is being done in #11133. The pubkey change is being done in #11073.
fanquake closed this on Oct 12, 2017
laanwj commented at 11:41 AM on October 12, 2017: member

@C0deAi @fanquake thanks for the reminder anyhow, those two PRs are now merged.
bitcoin locked this on Sep 8, 2021

Contributors