Make GetDataDir return absolute paths #1133

pull sipa wants to merge 1 commits into bitcoin:master from sipa:abspath changing 4 files +12 −7

sipa commented at 1:00 PM on April 22, 2012: member

Fixes #1125.
luke-jr commented at 1:06 PM on April 22, 2012: member

Does this resolve symbolic links? (I don't think that is proper behaviour, if so)
sipa commented at 1:11 PM on April 22, 2012: member

I don't think boost::filesystem::system_complete does that. This commit changes the behaviour back to what it was before ee12c3d60c4 (except that the suggested bitcoin.conf file in case of a missing rpcpassword now has the correct file path).
laanwj commented at 3:30 PM on April 22, 2012: member

This breaks the UI build :-)

(There's also a call to ReadConfigFile there that assumes that the result is a bool).
Make GetDataDir return absolute paths f4203de302
sipa commented at 3:39 PM on April 22, 2012: member

Fixed.
laanwj commented at 3:43 PM on April 22, 2012: member

ACK
jgarzik commented at 4:02 PM on April 22, 2012: contributor

ACK
gavinandresen commented at 9:23 PM on April 22, 2012: contributor

ACK
sipa referenced this in commit ef758662c5 on Apr 22, 2012
sipa merged this on Apr 22, 2012
sipa closed this on Apr 22, 2012
sipa cross-referenced this on Apr 22, 2012 from issue Relative -datadir=... broken by laanwj
coblee referenced this in commit 6551cfa342 on Jul 17, 2012
sipa deleted the branch on Jun 23, 2017
suprnurd referenced this in commit b11cc8f1a8 on Dec 5, 2017
lateminer referenced this in commit e9a5100f50 on Jan 22, 2019
lateminer referenced this in commit d159cb1878 on Dec 25, 2019
hebasto cross-referenced this on Oct 16, 2020 from issue Strip any trailing `/` in -datadir and -blocksdir paths by hebasto
bitcoin locked this on Sep 8, 2021

Contributors

Linked (view graph)

#1125 Relative -datadir=... broken #20080 Strip any trailing `/` in -datadir and -blocksdir paths