Ignore old format estimation file #11273

pull murchandamus wants to merge 1 commits into bitcoin:master from murchandamus:ignoreOldFeeEstimates changing 1 files +3 −26

murchandamus commented at 8:35 PM on September 7, 2017: contributor

The fee estimation data format changed from 0.14.x to 0.15.0, so we should no longer read the old data. H/T @jnewbery, @morcos

Pending testing.
laanwj commented at 8:39 PM on September 7, 2017: member

Is this just a cleanup or does this result in crashes/misestimations?
fanquake added the label TX fees and policy on Sep 7, 2017
in src/policy/fees.cpp:947 in 9b1d851f0f outdated
```
 968 | -            for (unsigned int i = 0; i < tempBuckets.size(); i++) {
 969 | -                tempMap[tempBuckets[i]] = i;
 970 | -            }
 971 | -        }
 972 | -        else { // nVersionThatWrote >= 149900
 973 | +        if (nVersionThatWrote > 149900) {
```
MarcoFalke commented at 9:48 PM on September 7, 2017:

This will always evaluate to false, as nVersionThatWrote is currently ==149900

laanwj commented at 10:41 PM on September 7, 2017:

I don't think so - on 0.15.0 it should be 150000 on master it should be 159900

MarcoFalke commented at 7:04 PM on September 9, 2017:

Mixed that up as nVersionRequired, sorry.
murchandamus force-pushed on Sep 7, 2017
Ignore old format estimation file 3a3a9f978b
murchandamus force-pushed on Sep 7, 2017
morcos commented at 6:48 PM on September 9, 2017: member

@laanwj This is meant to just be cleanup. The code to process the old file was left in under the thought we might provide a transition, but then we never did. Which reminds me, we should mention in the release notes that upgrading starts your estimates over again.
meshcollider cross-referenced this on Sep 10, 2017 from issue doc: Old fee_estimates.dat are discarded by 0.15.0 by MarcoFalke
TheBlueMatt commented at 4:45 PM on September 11, 2017: contributor

There are also similar cleanups to be had in TxConfirmStats::Read.
murchandamus commented at 4:44 AM on September 26, 2017: contributor

@jnewbery and I tested this at CDT. It will only refrain from loading estimation files created by the previous version as they are not compatible with the new estimation file.
jnewbery commented at 1:29 PM on September 26, 2017: member

@Xekyo care to respond to @TheBlueMatt's comment? There are a couple of if statements in TxConfirmStats::Read that are now redundant:https://github.com/bitcoin/bitcoin/blob/67879b7c443144e479c763f64abb9c1ed7e44eaa/src/policy/fees.cpp#L415 and https://github.com/bitcoin/bitcoin/blob/67879b7c443144e479c763f64abb9c1ed7e44eaa/src/policy/fees.cpp#L444 This PR should also clean up that code.
laanwj commented at 3:58 PM on November 30, 2017: member

Ping @Xekyo , if you include @TheBlueMatt's nits this is ready for merge.
laanwj added the label Up for grabs on Dec 19, 2017
laanwj renamed this:
~~WIP: Ignore old format estimation file~~
Ignore old format estimation file
on Dec 19, 2017
laanwj commented at 4:03 PM on December 19, 2017: member

utACK 3a3a9f9 I'm going to merge this. Removing this redundant code is clearly an improvement, and the other things suggested can be done later (added "up for grabs" tag).
laanwj merged this on Dec 19, 2017
laanwj closed this on Dec 19, 2017
laanwj referenced this in commit cdd6bbf10a on Dec 19, 2017
promag commented at 4:19 PM on December 19, 2017: member

utACK cdd6bbf.
TheBlueMatt cross-referenced this on Dec 19, 2017 from issue Remove dead feeest-file read code for old versions by TheBlueMatt
MarcoFalke removed the label Up for grabs on Dec 19, 2017
laanwj referenced this in commit 1fb34e0d1f on Dec 20, 2017
PastaPastaPasta referenced this in commit af1fce3aef on Feb 13, 2020
PastaPastaPasta referenced this in commit a22ab27e06 on Feb 13, 2020
PastaPastaPasta referenced this in commit 7f431e3955 on Feb 27, 2020
PastaPastaPasta referenced this in commit 1a57b6ac34 on Feb 27, 2020
PastaPastaPasta referenced this in commit b871cda635 on Feb 27, 2020
PastaPastaPasta referenced this in commit 71ca6a3452 on Feb 27, 2020
PastaPastaPasta referenced this in commit 4dd3124245 on Feb 27, 2020
PastaPastaPasta referenced this in commit 4a7a7cdfa2 on Feb 27, 2020
ckti referenced this in commit 2bb2426e1c on Mar 28, 2021
ckti referenced this in commit ac22981e2f on Mar 28, 2021
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#11295 doc: Old fee_estimates.dat are discarded by 0.15.0 #11951 Remove dead feeest-file read code for old versions