Follow up of #11117, this patch removes an extra unnecessary destination decoding that was identified while reviewing #11117. It is also the only case where IsValidDestinationString is called before DecodeDestination.
For reference see comment.
Remove duplicate destination decoding #11259
pull promag wants to merge 2 commits into bitcoin:master from promag:2017-09-remove-duplicate-destination-decoding changing 2 files +2 −19-
promag commented at 8:51 PM on September 6, 2017: member
- laanwj added the label Refactoring on Sep 6, 2017
-
laanwj commented at 10:10 PM on September 6, 2017: member
-
sipa commented at 10:18 PM on September 6, 2017: member
utACK 6bc6e241176b4a3acd1be2c12b7ffa7f1f65bd56
-
meshcollider commented at 10:19 PM on September 6, 2017: contributor
-
Remove unused GetKeyID and IsScript methods from CBitcoinAddress 8d0041e607
-
Remove duplicate destination decoding 86e6dd4b63
- promag force-pushed on Sep 6, 2017
-
promag commented at 10:52 PM on September 6, 2017: member
As per @laanwj suggestion on IRC, added a commit to remove unused methods that caused compile warnings:
base58.cpp:308:6: warning: ‘bool {anonymous}::CBitcoinAddress::IsScript() const’ defined but not used [-Wunused-function] base58.cpp:298:6: warning: ‘bool {anonymous}::CBitcoinAddress::GetKeyID(CKeyID&) const’ defined but not used [-Wunused-function]Also rebased.
-
sipa commented at 11:19 PM on September 6, 2017: member
utACK 8d0041e607a0e5bff52152f3d8af504f3703baa7
-
laanwj commented at 11:20 PM on September 6, 2017: member
Thanks. re-utACK 86e6dd4b6, builds without warnings (except in leveldb, which we can't do anything about here) now.
- laanwj merged this on Sep 6, 2017
- laanwj closed this on Sep 6, 2017
- laanwj referenced this in commit 089b742a21 on Sep 6, 2017
- cculianu referenced this in commit 3648e1bde2 on Sep 27, 2017
- dagurval cross-referenced this on Jan 19, 2018 from issue Prepare for non-Base58 addresses by dagurval
- str4d cross-referenced this on Apr 20, 2018 from issue Implement Sapling Bech32 address format by str4d
- str4d cross-referenced this on Apr 23, 2018 from issue Bech32 encoding support by str4d
- zkbot referenced this in commit 2c1f65d6e2 on Apr 23, 2018
- zkbot referenced this in commit 1c2f24793b on Apr 24, 2018
- zkbot referenced this in commit d5b558ba5b on Apr 25, 2018
- zkbot referenced this in commit 962ba99b36 on Apr 25, 2018
- str4d cross-referenced this on May 1, 2018 from issue Refactor t-address encoding by str4d
- zkbot referenced this in commit 88849fa479 on May 3, 2018
- zkbot referenced this in commit d97bfb766b on May 4, 2018
- mkjekk referenced this in commit 78344bb4e1 on Aug 12, 2018
- mkjekk referenced this in commit cadb67b07b on Aug 12, 2018
- PastaPastaPasta referenced this in commit 1e7d9e78d7 on Feb 12, 2020
- PastaPastaPasta referenced this in commit bf7167776d on Feb 13, 2020
- PastaPastaPasta referenced this in commit a321e6195f on Feb 29, 2020
- furszy cross-referenced this on Jun 12, 2020 from issue Prepare for non-Base58 addresses [Step 3] by furszy
- random-zebra referenced this in commit c157deb76b on Jul 5, 2020
- ckti referenced this in commit c226d4d276 on Mar 28, 2021
- bitcoin locked this on Sep 8, 2021
Contributors
Labels